[vim/vim] Add Jsonnet support (Issue #11073)

Cezary Drożak

unread,

Sep 7, 2022, 4:54:16 AM9/7/22

to vim/vim, Subscribed

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
Jsonnet files are currently not recognized and require an extension: google/vim-jsonnet.

Describe the solution you'd like
Add Jsonnet support based on the Google plugin in Vim.

I may take a stab at it later, but I worry about license and proper crediting. There is more than one author and the plugin is distributed under the Apache license. I'm not sure how I should apply the license requirements here.

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Christian Clason

unread,

Sep 7, 2022, 5:31:01 AM9/7/22

to vim/vim, Subscribed

The filetype detection is so trivial, it requires neither license nor crediting. Just open a PR adding the extensions to runtime/filetype.vim and src/testdir/test_filetype.vim.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Clason

unread,

Sep 7, 2022, 5:32:14 AM9/7/22

to vim/vim, Subscribed

(The syntax and ftplugin files are a different matter; if you want these added to Vim's runtime files, you should open an issue at the vim-json repo asking for permission.)

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Sep 7, 2022, 8:04:18 AM9/7/22

to vim/vim, Subscribed

> Jsonnet files are currently not recognized and require an extension:

> [google/vim-jsonnet](https://github.com/google/vim-jsonnet).
>
> **Describe the solution you'd like**

> Add Jsonnet support based on the Google plugin in Vim.
>
> I may take a stab at it later, but I worry about license and proper
> crediting. There is more than one author and the plugin is distributed
> under the Apache license. I'm not sure how I should apply the license
> requirements here.

The Apache license should be OK, it doesn't conflict with the Vim
license. But it's always good to get a confirmation from the author(s).

I'm more worried about maintenance, it seems last change was three years
ago. But perhaps it's just "stable".

Feel free to make a PR for the filetype detection.

--
hundred-and-one symptoms of being an internet addict:
22. You've already visited all the links at Yahoo and you're halfway through
Lycos.

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Sep 8, 2022, 9:42:37 AM9/8/22

to vim/vim, Subscribed

Closed #11073 as completed via 2a4c885.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Maxime Brunet

unread,

Oct 20, 2022, 2:48:08 PM10/20/22

to vim/vim, Subscribed

FYI I have opened PR #11412 for a correction: s/libjsonnet/libsonnet/ :)

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward