[vim/vim] tabpanel: can only drag the active tab (Issue #17986)

[Char]

char101 created an issue (vim/vim#17986)

Steps to reproduce

1. enable tabpanel, open several tabs
2. try to drag inactive tab
3. the tab is selected, but cannot be dragged
4. the mouse need to be released and then dragged to move the tab

This is not a dealbreaker, the tab can still be dragged after selected. But from an UX perspective, in my opinion, it is pretty weird that only the active tab can be dragged. If my memory is not wrong, in the initial tabpanel implementation, inactive tab can be dragged.

There is also another weird behavior where left clicking in the empty tabpanel area randomly selects tab 1 to 4 and then suddenly jumps to the last tab (when there is >= 5 tabs).

Expected behaviour

Inactive tab can be dragged.

Version of Vim

9.1.1627

Environment

GVim
Windows 10

Logs and stack traces

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/17986@github.com>

[Naruhiko Nishino]

rbtnn left a comment (vim/vim#17986)

There is also another weird behavior where left clicking in the empty tabpanel area randomly selects tab 1 to 4 and then suddenly jumps to the last tab (when there is >= 5 tabs).

When left-clicking on the empty area of the tabpanel, it moves to the next tab page of the current one. This is the same behavior as the tabline. I think the sudden jump to the last tab happens because the interval between left-clicks is too short, so it’s interpreted as a double-click.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/17986/3193569188@github.com>

[Christian Brabandt]

Closed #17986 as completed via 62f5be6.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/17986/issue_event/19186861501@github.com>

[Char]

char101 left a comment (vim/vim#17986)

Thank you for the pull request, I have compiled the latest vim version and now inactive tab can be dragged.

When left-clicking on the empty area of the tabpanel, it moves to the next tab page of the current one. This is the same behavior as the tabline. I think the sudden jump to the last tab happens because the interval between left-clicks is too short, so it’s interpreted as a double-click.

I think so too. But here is the problem, if clicking on the empty tabpanel area selects the next tab, what if I want to select the next 2nd or 3rd tab, then I will definitely click 2 or 3 times and do a fast click, and therefore the last 2 clicks will be registered as double click.

So these 2 actions (selecting the 2nd next tab and opening a new tab) basically overlaps.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/17986/3193706437@github.com>