[vim/vim] Crash when using '?' as separator for :s (PR #14832)

[zeertzjq]

Problem: Crash when using '?' as separator for :s and pattern contains
escaped '?'s.
Solution: Always compute startplen.

Fix neovim/neovim#28935

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/14832

Commit Summary

• d980790 Crash when using '?' as separator for :s

File Changes

(2 files)

• M src/regexp.c (4)
• M src/testdir/test_substitute.vim (10)

Patch Links:

• https://github.com/vim/vim/pull/14832.patch
• https://github.com/vim/vim/pull/14832.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14832@github.com>

[Christian Brabandt]

Thanks for this and watching out for problems. I was afraid that the strlen() refactor could cause issues like this.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14832/c2127447813@github.com>

[Christian Brabandt]

Closed #14832.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14832/issue_event/12911579906@github.com>

[Christian Brabandt]

included as of 98ec4754e

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14832/c2127459586@github.com>