[vim/vim] Try to process WM_SETFOCUS event soon (PR #19167)
MURAOKA Taro
Problem: In gvim on Windows, a certain problem can occur when the WM_SETFOCUS event sent after an external command is not processed immediately.
The problem is that Test_normal11_showcmd may fail when running the test_normal.vim test. Investigation revealed that the trigger was an external command executed in the previous test,
Test_mouse_shape_after_failed_change, when two tests were executed consecutively. In gvim on Windows, a WM_SETFOCUS event will be sent when an external command finishes executing. This WM_SETFOCUS event is not processed immediately, but rather by redraw, which is expected to update showcmd. Because it is queued in typebuf at this time, clear_showcmd(), which expects typebuf to be empty, cannot update showcmd.
Solution: After posting WM_SETFOCUS, run the message loop to process it as quickly as possible.
Also added a test that simulates the above problem.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19167
Commit Summary
- 208d41a Try to process WM_SETFOCUS event soon
File Changes
(2 files)
- M src/os_win32.c (4)
- M src/testdir/test_normal.vim (29)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
MURAOKA Taro
koron left a comment (vim/vim#19167)I don't know why this isn't happening with the existing CI. I think it's probably due to one of the if_xxx interfaces.
I've disabled the patch so you can see that the newly added tests fail without the patch. See below:
- The branch: https://github.com/koron/vim/tree/refs/heads/not-fix-unhandled-setfocus-causing-problems-19167
- Changes from this PR: koron@b84a76a
- CI summary: https://github.com/koron/vim/actions/runs/20921874887
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19167)Thanks, but this will go after the release.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Ari4ka
@Ari4ka approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.