[vim/vim] tests: redundant and strange use of :execute in test_ins_complete (PR #17143)

7 views
Skip to first unread message

zeertzjq

unread,
Apr 17, 2025, 6:59:18 PM4/17/25
to vim/vim, Subscribed

Problem: Redundant and strange use of :execute in test_ins_complete.
Solution: Use the executed command directly.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/17143

Commit Summary

  • b10c7ee tests: redundant and strange use of :execute in test_ins_complete

File Changes

(1 file)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17143@github.com>

zeertzjq

unread,
Apr 17, 2025, 7:08:12 PM4/17/25
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • 5cfe625 tests: redundant and strange use of :execute in test_ins_complete.vim

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17143/before/0ca1e15e8c8878eeeef315d2c64743cf53886219/after/5cfe6253d14bb60f5c61390f2d829cf471df8024@github.com>

zeertzjq

unread,
Apr 17, 2025, 7:12:22 PM4/17/25
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • d50a4f8 tests: redundant and strange use of :execute in test_ins_complete.vim

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17143/before/5cfe6253d14bb60f5c61390f2d829cf471df8024/after/d50a4f89cad36f45d9a298570788cc90e8fed020@github.com>

Christ van Willegen

unread,
Apr 18, 2025, 2:16:32 AM4/18/25
to vim...@googlegroups.com, nor...@github.com, vim/vim, Push
Hi,

Op vr 18 apr 2025 01:12 schreef zeertzjq <vim-dev...@256bit.org>:

@zeertzjq pushed 1 commit.

  • d50a4f8 tests: redundant and strange use of :execute in test_ins_complete.vim

Are you still working on this PR? Could you fix this typo too:



index 0e3711eb75530..52721bd532ad0 100644
--- a/src/ops.c
+++ b/src/ops.c
@@ -248,11 +248,11 @@ get_vts_sum(int *vts_array, int index)
     int	sum = 0;
     int	i;
 
-    // Perform the summation for indeces within the actual array.
+    // Perform the summation for indices within the actual array.
     for (i = 1; i <= index && i <= vts_array[0]; i++)
 	sum += vts_array[i];
 
-    // Add topstops whose indeces exceed the actual array.
+    // Add topstops whose indices exceed the actual array.


I guess that those should be tabstops...

Christ van Willegen

Christian Brabandt

unread,
Apr 18, 2025, 4:50:17 AM4/18/25
to vim...@googlegroups.com, nor...@github.com, vim/vim, Push

On Fri, 18 Apr 2025, Christ van Willegen wrote:

> index 0e3711eb75530..52721bd532ad0 100644
> --- a/src/ops.c
> +++ b/src/ops.c
> @@ -248,11 +248,11 @@ get_vts_sum(int *vts_array, int index)
> int sum = 0;
> int i;
>
> - // Perform the summation for indeces within the actual array.
> + // Perform the summation for indices within the actual array.
> for (i = 1; i <= index && i <= vts_array[0]; i++)
> sum += vts_array[i];
>
> - // Add topstops whose indeces exceed the actual array.
> + // Add topstops whose indices exceed the actual array.
>
>
>
> I guess that those should be tabstops...

Thanks, I'll squash it in.

Thanks,
Christian
--
Rap music is just computerised crap. I listen to Top of the Pops and after
three songs I feel like killing someone.
-- George Harrison

Christian Brabandt

unread,
Apr 18, 2025, 5:00:53 AM4/18/25
to vim/vim, Subscribed

Closed #17143 via 9880097.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17143/issue_event/17317702399@github.com>

Reply all
Reply to author
Forward
0 new messages