[vim/vim] fix(popup-image): gtk2,3 avoid update_cursor, popup_image_clear_cairo (PR #20610)
dezza
This one integrates better with existing source and avoids update_cursor.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20610
Commit Summary
- d52c29e fix(gtk2): use gui.drawarea->window
- 1a86b04 fix(gtk2,3): popup-images lost when unfocused
- fcc5887 fix(gtk2,3): popup-images hidden by cursor
- 2e1d2e3 fix(preproc): GTK_CHECK_VERSION undefined on some platforms
- b74577a fix: indent
- 64237a1 Merge upstream
- 5cf3b1c fix(popup-image): gtk2,3 avoid update_cursor, popup_image_clear_cairo
File Changes
(3 files)
- M src/auto/configure (4780)
- M src/gui.c (10)
- M src/popupwin.c (42)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20610)Thanks. One question: the last hunk contains this:
- # ifdef FEAT_IMAGE_GDI + # if defined(FEAT_IMAGE_GDI) || defined(FEAT_IMAGE_CAIRO)
Do we need the same change here? https://github.com/vim/vim/blob/fa3680c6fa93b6bb2c96ae536f56c56750477cfc/src/gui.c#L2777-L2785
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.