Commit: patch 9.2.0135: memory leak in eval_tuple()

4 views
Skip to first unread message

Christian Brabandt

unread,
Mar 10, 2026, 4:02:00 PM (13 days ago) Mar 10
to vim...@googlegroups.com
patch 9.2.0135: memory leak in eval_tuple()

Commit: https://github.com/vim/vim/commit/e945350f11c7687638c3c596e66c39cfaef37e74
Author: Huihui Huang <625...@qq.com>
Date: Tue Mar 10 19:49:55 2026 +0000

patch 9.2.0135: memory leak in eval_tuple()

Problem: memory leak in eval_tuple() in src/tuple.c
Solution: Free variable tuple on early return (Huihui Huang).

closes: #19628

Signed-off-by: Huihui Huang <625...@qq.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/tuple.c b/src/tuple.c
index 28fb59888..b7a420e94 100644
--- a/src/tuple.c
+++ b/src/tuple.c
@@ -517,7 +517,7 @@ eval_tuple(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int do_error)
{
// Add the first item to the tuple from "rettv"
if (tuple_append_tv(tuple, rettv) == FAIL)
- return FAIL;
+ goto failret;
// The first item in "rettv" is added to the tuple. Set the rettv
// type to unknown, so that the caller doesn't free it.
rettv->v_type = VAR_UNKNOWN;
diff --git a/src/version.c b/src/version.c
index 4d12e98c6..cfe11e4c0 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 135,
/**/
134,
/**/
Reply all
Reply to author
Forward
0 new messages