[vim/vim] fix: Test_aucmd_win_scroll_multibyte flakiness (PR #20919)

0 views
Skip to first unread message

Samuel Schlesinger

unread,
11:41 AM (9 hours ago) 11:41 AM
to vim/vim, Subscribed

Test_aucmd_win_scroll_multibyte compares the window topline before and after using the autocommand window, which assumes the window geometry doesn't change in between. In the GUI a resize can be processed while the test runs, legitimately changing the topline, which makes the test flaky. It appears to have failed on master, for instance, and it failed on my other recent PR as well #20914.

The solution is to skip this test in the GUI. The logic in plines_win_col being tested isn't GUI specific, so it stays covered by the non-GUI test configurations.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20919

Commit Summary

  • e8de746 test: Test_aucmd_win_scroll_multibyte is flaky in the GUI

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20919@github.com>

h_east

unread,
12:17 PM (8 hours ago) 12:17 PM
to vim/vim, Subscribed
h-east left a comment (vim/vim#20919)

Dupicate to #20913


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20919/c5159156792@github.com>

Reply all
Reply to author
Forward
0 new messages