[vim/vim] window: fix last_status_rec() taking N rows for FR_ROW instead of one (PR #19688)

8 views
Skip to first unread message

h_east

unread,
Mar 14, 2026, 2:08:19 PM (4 days ago) Mar 14
to vim/vim, Subscribed

When 'laststatus' changes, last_status_rec() for FR_ROW called last_status_rec() for each child independently. Each child searched for a donor frame and took a row, so N windows caused N rows to be taken instead of one shared row.

Fix by letting only the first leaf take a row; subsequent leaves share it with matching height adjustments. Also handle mixed status line heights from window-local 'statuslineopt'.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19688

Commit Summary

  • 4f5f271 window: fix last_status_rec() taking N rows for FR_ROW instead of one

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688@github.com>

h_east

unread,
Mar 14, 2026, 2:36:22 PM (4 days ago) Mar 14
to vim/vim, Push

@h-east pushed 1 commit.

  • a901429 fix last_status_rec() taking N rows for FR_ROW instead of one


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/before/4f5f271232b898306ffe7048bd09d1a4d9ca7383/after/a901429828a76887c8c08057cee046ad2f73a328@github.com>

h_east

unread,
Mar 16, 2026, 4:57:35 AM (2 days ago) Mar 16
to vim/vim, Push

@h-east pushed 1 commit.

  • ec24b0b fix last_status_rec() taking N rows for FR_ROW instead of one

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/before/a901429828a76887c8c08057cee046ad2f73a328/after/ec24b0b3a88575944a75754b8aed81fd49f1c16e@github.com>

h_east

unread,
Mar 17, 2026, 8:55:11 AM (20 hours ago) Mar 17
to vim/vim, Push

@h-east pushed 1 commit.

  • 61437c1 fix last_status_rec() taking N rows for FR_ROW instead of one

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/before/ec24b0b3a88575944a75754b8aed81fd49f1c16e/after/61437c106a60ce3a7c29d8e5249aa1f83e26c45d@github.com>

h_east

unread,
Mar 17, 2026, 10:34:16 AM (18 hours ago) Mar 17
to vim/vim, Push

@h-east pushed 1 commit.

  • 3924614 Changed the test method to VerifyScreenDump.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/before/61437c106a60ce3a7c29d8e5249aa1f83e26c45d/after/3924614186760ca19f0802c406cea64667043223@github.com>

h_east

unread,
Mar 17, 2026, 10:36:57 AM (18 hours ago) Mar 17
to vim/vim, Subscribed
h-east left a comment (vim/vim#19688)

@chrisbra It can be merged.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/c4075452377@github.com>

Christian Brabandt

unread,
Mar 17, 2026, 4:58:17 PM (12 hours ago) Mar 17
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#19688)

thanks


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/c4077965731@github.com>

Christian Brabandt

unread,
Mar 17, 2026, 5:07:17 PM (12 hours ago) Mar 17
to vim/vim, Subscribed

Closed #19688 via 1f4cd5f.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19688/issue_event/23659334417@github.com>

Reply all
Reply to author
Forward
0 new messages