[vim/vim] colorscheme koehler lost readability in update vim 8.x -> 9.0.x (Issue #13317)

41 views
Skip to first unread message

jeanluc2020

unread,
Oct 11, 2023, 4:10:41 PM10/11/23
to vim/vim, Subscribed

Steps to reproduce

  1. Open any file in later vim-9 versions
  2. :colorscheme koehler
  3. Look at the colors - comments are almost unreadable
  4. Example how things look now is after TOhtml: http://gott-gehabt.de/800_wer_wir_sind/thomas/Homepage/Computer/perl/theweeklychallenge-238-1.html

Expected behaviour

Everything looks more readable under ":colorscheme koehler" - I wrote the colorscheme for readability in the first place.
Example how things looked back in vim-8 after TOhtml: http://gott-gehabt.de/800_wer_wir_sind/thomas/Homepage/Computer/perl/theweeklychallenge-238-1.html

  1. the background is black, not kind of dark-grey
  2. comments are cyan and therefore better readable on black background
  3. function and variable names also have different colors

Version of Vim

Vi IMproved 9.0, Included patches: 1-1378, 1499

Environment

Operating System: Debian 12.2 (just updated from 11.x)
terminal: xterm
value of $TERM: screen
shell: zsh-5.9

Logs and stack traces

No response


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317@github.com>

Christian Brabandt

unread,
Oct 11, 2023, 4:18:36 PM10/11/23
to vim/vim, Subscribed

I suppose this is essentially the same as #10449 which mentions several alternatives/solutions/work-arounds


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758470429@github.com>

Christian Brabandt

unread,
Oct 11, 2023, 4:19:43 PM10/11/23
to vim/vim, Subscribed

btw: you mentioned two times the same link


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758472069@github.com>

Lifepillar

unread,
Oct 11, 2023, 6:08:08 PM10/11/23
to vim/vim, Subscribed

My Linux xterm has $TERM set to xterm. Is screen correct for your setup?

What is the output of :set t_Co?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758615137@github.com>

Yee Cheng Chin

unread,
Oct 11, 2023, 8:00:02 PM10/11/23
to vim/vim, Subscribed

The colors look correct for me (black background, cyan comments, etc). Is this some terminal issues?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758712121@github.com>

jeanluc2020

unread,
Oct 12, 2023, 1:25:37 AM10/12/23
to vim/vim, Subscribed

My mistake, I meant to use http://gott-gehabt.de/800_wer_wir_sind/thomas/Homepage/Computer/perl/theweeklychallenge-237-1.html as the "good" example.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758932102@github.com>

jeanluc2020

unread,
Oct 12, 2023, 1:33:03 AM10/12/23
to vim/vim, Subscribed

My Linux xterm has $TERM set to xterm. Is screen correct for your setup?

Since I'm running screen inside of xterm, yes this is correct / expected.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758937794@github.com>

jeanluc2020

unread,
Oct 12, 2023, 1:38:59 AM10/12/23
to vim/vim, Subscribed

I suppose this is essentially the same as #10449 which mentions several alternatives/solutions/work-arounds

Yeah, downloading the original koehler.vim into ~/.vim/colors solves it for me.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758941936@github.com>

jeanluc2020

unread,
Oct 12, 2023, 1:45:17 AM10/12/23
to vim/vim, Subscribed

What is the output of :set t_Co?

t_Co=8


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758946963@github.com>

jeanluc2020

unread,
Oct 12, 2023, 1:56:31 AM10/12/23
to vim/vim, Subscribed

The colors look correct for me (black background, cyan comments, etc). Is this some terminal issues?

I don't know exactly what is in play here, but with TERM=xterm-256colors or TERM=xterm I also get no cyan comments if I don't use the legacy colorscheme.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1758955596@github.com>

Christian Brabandt

unread,
Oct 12, 2023, 3:46:48 AM10/12/23
to vim/vim, Subscribed

t_Co=8

While that is correct for a plain old xterm, I suppose you rather want to use xterm-256color (without the s) to have at least 256 colors available (which xterm supports for a very long time). I haven't seen a terminal that only supports 8 colors in years.

If you want to keep TERM=xterm for whathever reasons, you can also just set :set t_Co=256 in your .vimrc to force to use 256 colors.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1759103907@github.com>

Christian Brabandt

unread,
Oct 12, 2023, 8:25:35 AM10/12/23
to vim/vim, Subscribed

I supposed this can be closed now.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1759506038@github.com>

Christian Brabandt

unread,
Oct 12, 2023, 8:25:48 AM10/12/23
to vim/vim, Subscribed

Closed #13317 as not planned.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/13317/issue_event/10630939772@github.com>

D. Ben Knoble

unread,
Oct 12, 2023, 7:44:05 PM10/12/23
to vim/vim, Subscribed

More appropriate is to make sure TERM makes sense and that the corresponding terminfo entry reports appropriate values. For example, with tmux I create a tmux-256color terminfo and use it for TERM inside tmux (forcibly assuming that the underlying terminal also supports it). I even enable some special things conditionally, including resetting Vim’s 'term': https://github.com/benknoble/Dotfiles/blob/42e735921210a6bc6da3932c0d88d54db613693e/links/vim/vimrc#L370 Arguably getting this right for tmux/screen is hard, because their info depends more on the combination of underlying term and the program itself.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/13317/1760541882@github.com>

Reply all
Reply to author
Forward
0 new messages