[vim/vim] the ja.euc-jp.po file is generated wrong on macOS (PR #21082)
h_east
Problem: The macOS CI job fails now and then on the check of ja.euc-jp.po.
The iconv of macOS turns a backslash that follows a multibyte
character into a fullwidth one, which breaks the escaping. The
file in the repository is correct, it is only regenerated when a
checkout leaves ja.po newer, which is why the failure comes and
goes.
Solution: Convert to EUC-JP-MS, which keeps the backslash and gives the same
result otherwise.
Measured on a macOS runner, converting ja.po and dumping the msgstr of E1078:
-t EUC-JP a1 a3 a1 c0 22 。 ＼ "
-t EUC-JP-MS a1 a3 5c 22 。 \ "
-t eucJP-open a1 a3 5c 22 。 \ "
On Linux, converting the whole file with EUC-JP and with EUC-JP-MS gives byte
identical output, and it matches the ja.euc-jp.po in the repository, so
regenerating produces no diff.
Verified by removing ja.euc-jp.po on a branch to force the conversion: all
six macOS jobs pass with the change and fail without it.
The four 。\n in the file are corrupted the same way, but the check only
counts % and does not notice them.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21082
Commit Summary
- cddb54d the ja.euc-jp.po file is generated wrong on macOS
File Changes
(1 file)
- M src/po/Makefile (5)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.