[vim/vim] pum opacity corrupts wide background chars (PR #20017)

mattn

unread,

Apr 19, 2026, 11:51:52 AM (yesterday) Apr 19

to vim/vim, Subscribed

With pumopt=opacity, the popup-menu blend path processes each cell
independently, so the trailing half of a background wide character is
overwritten after screen_char() has already drawn the full wide glyph.
Background wide characters around the popup disappear or remain as
isolated halves.

Mirror the trailing-cell skip from the screen_opacity_popup path to
the screen_pum_blend branch.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20017

Commit Summary

d00d1a0 patch 9.2.xxxx: pum opacity corrupts wide background chars

File Changes

(1 file)

M src/screen.c (17)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 12:01:23 PM (yesterday) Apr 19

to vim/vim, Push

@mattn pushed 2 commits.

e803eec pum opacity: fix wide background char corruption
b0ba41e pum opacity: blend popup text bg with underlying bg

—
View it on GitHub.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 12:15:23 PM (yesterday) Apr 19

to vim/vim, Subscribed

mattn left a comment (vim/vim#20017)

I found one another issue related on this.
image.png (view on web)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 12:19:42 PM (yesterday) Apr 19

to vim/vim, Push

@mattn pushed 1 commit.

9f2e40e pum opacity: preserve right border when bg wide char spills

—
View it on GitHub.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 12:22:04 PM (yesterday) Apr 19

to vim/vim, Subscribed

mattn left a comment (vim/vim#20017)

Fixed
image.png (view on web)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 12:38:27 PM (yesterday) Apr 19

to vim/vim, Push

@mattn pushed 1 commit.

6f2e268 pum opacity: use popup attrs on opaque popup text

—
View it on GitHub.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 19, 2026, 2:54:25 PM (yesterday) Apr 19

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20017)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 19, 2026, 2:56:58 PM (yesterday) Apr 19

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20017)

Hm, can you add a test for this change?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 7:52:37 PM (22 hours ago) Apr 19

to vim/vim, Push

@mattn pushed 1 commit.

d3e1eae test: add screendumps for pumopt opacity with multibyte text

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 7:55:40 PM (22 hours ago) Apr 19

to vim/vim, Subscribed

mattn left a comment (vim/vim#20017)

It seems like a few more bugs need fixing.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 8:37:29 PM (22 hours ago) Apr 19

to vim/vim, Push

@mattn pushed 1 commit.

ac7ae8b pum opacity: fix trailing-cell handling near popup text boundary

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 8:37:52 PM (22 hours ago) Apr 19

to vim/vim, Subscribed

mattn left a comment (vim/vim#20017)

Added tests for pumopt opacity against multibyte background text and popup items.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 8:39:40 PM (22 hours ago) Apr 19

to vim/vim, Push

@mattn pushed 1 commit.

6096b5a test: add screendump for pum opacity with offset multibyte bg

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

mattn

unread,

Apr 19, 2026, 8:40:42 PM (22 hours ago) Apr 19

to vim/vim, Subscribed

mattn left a comment (vim/vim#20017)

https://github.com/user-attachments/assets/37196c36-b443-4e51-b86c-f64d7f95bdbc

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

11:20 AM (7 hours ago) 11:20 AM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20017)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

11:43 AM (7 hours ago) 11:43 AM

to vim/vim, Subscribed

Closed #20017 via 73ba353.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward