[vim/vim] feature: support tab closing by middle button clicking on Windows (PR #10746)
regomne
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10746
Commit Summary
- 9a6bf4b feature: support tab closing by middle button clicking
File Changes
(1 file)
- M src/gui_w32.c (14)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Doesn't this make it too easy to close a tab?
Is using the middle mouse button a common way in MS-Windows to close a Tab?
Most mice don't even have a middle mouse button.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
K.Takata
Recent mice have a wheel and clicking it has the same effect.
Browsers like Chrome and Firefox support closing a tab by clicking a middle button, but it can be easily undone (e.g. Ctrl+Shift+T).
I'm not sure whether we should support it on Vim.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
K.Takata
Doesn't this make it too easy to close a tab?
Ah, maybe #10747 is a measure for this.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
regomne
The reason I put this pr is that most text editors in Windows that support tabs support closing a tab with the middle mouse button, such as VS Code, Sublime text, notepad++, Ultra Edit, Visual Studio.
Browsers like Chrome and Firefox support closing a tab by clicking a middle button, but it can be easily undone (e.g. Ctrl+Shift+T).
Browsers just reopen a closed tab instead of undone, as the behavior of interacting through js scripts in the page can be hardly undone correctly.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> The reason I put this pr is that most text editors in Windows that
> support tabs support closing a tab with the middle mouse button, such
> as VS Code, Sublime text, notepad++, Ultra Edit, Visual Studio.
>
> > Browsers like Chrome and Firefox support closing a tab by clicking a
> > middle button, but it can be easily undone (e.g. Ctrl+Shift+T).
>
> Browsers just reopen a closed tab instead of undone, as the behavior
> of interacting through js scripts in the page can be hardly undone
> correctly.
middle mouse click. I just checked Chrome on Linux and that appears to
support it too.
Only doing this on MS-Windows GUI is rather limited. Should at least do
it in all GUI versions. Perhaps we don't need it in a terminal (which
shows a text line for the tabs).
--
hundred-and-one symptoms of being an internet addict:
147. You finally give up smoking...because it made the monitor dirty.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
regomne
@brammool OK，I will try to add support for other platforms.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
regomne
@regomne pushed 1 commit.
- 300ec34 Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10746 (300ec34) into master (b18b496) will decrease coverage by
82.17%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #10746 +/- ## =========================================== - Coverage 82.47% 0.29% -82.18% =========================================== Files 152 152 Lines 177672 173427 -4245 Branches 40331 39908 -423 =========================================== - Hits 146528 520 -146008 - Misses 18948 172850 +153902 + Partials 12196 57 -12139
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 0.29% <ø> (ø) |
|
| linux | 0.29% <ø> (-82.18%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/float.c | 0.00% <0.00%> (-98.44%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-94.90%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-94.72%) |
⬇️ |
| src/arabic.c | 0.00% <0.00%> (-94.57%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-94.12%) |
⬇️ |
| src/typval.c | 0.00% <0.00%> (-92.47%) |
⬇️ |
| src/debugger.c | 0.00% <0.00%> (-92.23%) |
⬇️ |
| src/blob.c | 0.00% <0.00%> (-92.18%) |
⬇️ |
| src/vim9compile.c | 0.00% <0.00%> (-91.85%) |
⬇️ |
| src/ex_docmd.c | 0.00% <0.00%> (-91.81%) |
⬇️ |
| ... and 136 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
I tried this with Motif, but it looks like the "paste" functionality overrides it. When I press the middle mouse button some icon appears.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
regomne
I tried this with Motif, but it looks like the "paste" functionality overrides it. When I press the middle mouse button some icon appears.
It seems that the default behavior of middle button pressing in motif window is Drag&drop. I tried to turn off it according to the chapter "Turning Off Drag and Drop Functionality", but failed. Could you provide some help?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> > I tried this with Motif, but it looks like the "paste" functionality
> > overrides it. When I press the middle mouse button some icon
> > appears.
>
> It seems that the default behavior of middle button pressing in motif
> window is
> tried to turn off it according to the chapter "Turning Off Drag and
> Drop Functionality", but failed. Could you provide some help?
--
A computer program does what you tell it to do, not what you want it to do.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.