[vim/vim] Wildmenu popup-window is off when terminal job running in current tab page (Issue #10035)

bfrg

unread,

Mar 28, 2022, 12:14:28 AM3/28/22

to vim/vim, Subscribed

Steps to reproduce

Run vim --clean -c 'set wildoptions=pum | term'
In Vim, type <c-w>:h <tab>
Result: The popup-menu is not displayed directly above the command-line.

This happens only when the terminal job is still running. When running :term ls, and then typing <c-w>:e <tab>, the popup-menu is correctly displayed above the command-line.

Expected behaviour

Wildmenu pum should always be displayed right above the command-line.

Version of Vim

8.2.4639

Environment

Linux

Logs and stack traces

No response

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Mar 28, 2022, 2:54:11 PM3/28/22

to vim/vim, Subscribed

I cannot reproduce this. I also can't think of anything that influences this.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 28, 2022, 3:14:52 PM3/28/22

to vim_dev, reply+ACY5DGAATPVWRAUYCZ...@reply.github.com, vim/vim, Subscribed

Hi,

On Mon, Mar 28, 2022 at 11:54 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

I cannot reproduce this. I also can't think of anything that influences this.

I am able to reproduce this problem on MS-Windows but not on a Ubuntu system.

- Yegappan

vim-dev ML

unread,

Mar 28, 2022, 3:15:09 PM3/28/22

to vim/vim, vim-dev ML, Your activity

Hi,

On Mon, Mar 28, 2022 at 11:54 AM Bram Moolenaar ***@***.***>

wrote:

> I cannot reproduce this. I also can't think of anything that influences
> this.
>
>
>
I am able to reproduce this problem on MS-Windows but not on a Ubuntu
system.

- Yegappan

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

bfrg

unread,

Mar 28, 2022, 3:17:45 PM3/28/22

to vim/vim, vim-dev ML, Comment

I noticed when I first go to terminal-normal mode with <c-w>N before typing :h <tab>, everything is fine.

It seems to be related to my bash prompt. Can you reproduce it with a bash prompt that spans two lines?

For example:

export PS1="\u@\h in \w\n$ "

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

Yegappan Lakshmanan

unread,

Mar 30, 2022, 12:14:25 PM3/30/22

to vim_dev, reply+ACY5DGHKTUS4UWM773...@reply.github.com, vim/vim, vim-dev ML, Comment

Hi,

On Mon, Mar 28, 2022 at 12:17 PM bfrg <vim-dev...@256bit.org> wrote:

I noticed when I first go to terminal-normal mode with <c-w>N before typing :h <tab>, everything is fine.

It seems to be related to my bash prompt. Can you reproduce it with a bash prompt that spans two lines?

For example:
export PS1="\u@\h in \w\n$ "

I am able to reproduce the problem on Ubuntu by adding one or two dummy echo lines

to the .bashrc file. The attached patch fixes this problem. In the failing case, the

pum_display() function computes the context_lines as 2. In the working case, the

context_lines is set to 0. I am not sure whether the changes in the attached patch

is the correct way to fix this issue.

- Yegappan

pumpos.diff

vim-dev ML

unread,

Mar 30, 2022, 12:14:41 PM3/30/22

to vim/vim, vim-dev ML, Your activity

Hi,

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Mar 30, 2022, 5:11:15 PM3/30/22

to vim/vim, vim-dev ML, Comment

[For those reading this on github: the attachment was sent to the vim-dev maillist]

Since you can reproduce the problem, can you write a test that way? Probably using a screendump.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

Yegappan Lakshmanan

unread,

Mar 30, 2022, 9:45:44 PM3/30/22

to vim/vim, vim-dev ML, Comment

I have created PR #10050 with the fix and a test. But I think the changes to pum_display()
need to be reviewed. For a cmdline completion popup menu, pum_display() should not
use the curwin to compute the popup menu dimensions.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

bfrg

unread,

Mar 31, 2022, 12:58:09 AM3/31/22

to vim/vim, vim-dev ML, Comment

Thank you! Just tested it and can confirm that it fixes the issue.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

Bram Moolenaar

unread,

Mar 31, 2022, 7:34:45 AM3/31/22

to vim/vim, vim-dev ML, Comment

Closed #10035 via 1104a6d.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

Reply all

Reply to author

Forward