[vim/vim] virtual text property IDs are not recycled after deletion (PR #19823)

[h_east]

Problem: Virtual text property IDs are not recycled after deletion,
causing b_textprop_text growarray to grow indefinitely when
properties are repeatedly added and removed.

Solution: Scan for NULL entries in b_textprop_text to find reusable IDs
in get_textprop_id(), and reuse existing slots in
prop_add_one() when a recycled ID is returned.

Fixes: #19681

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19823

Commit Summary

• bcff3ff virtual text property IDs are not recycled after deletion

File Changes

(2 files)

• M src/testdir/test_textprop.vim (41)
• M src/textprop.c (36)

Patch Links:

• https://github.com/vim/vim/pull/19823.patch
• https://github.com/vim/vim/pull/19823.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19823@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19823)

Thanks, but I think this is already part of #19685

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19823/c4129128948@github.com>

[Paul Ollis]

paul-ollis left a comment (vim/vim#19823)

@chrisbra is correct. #19685 removes b_textprop_text.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19823/c4130387340@github.com>

[h_east]

h-east left a comment (vim/vim#19823)

#19685 (review)

First, I believe that bugs that can be addressed individually should be fixed on a case-by-case basis.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19823/c4130849739@github.com>