[vim/vim] Cmdline history not updated when mapping both <Up> and <CR> (PR #18607)
zeertzjq
Problem: Cmdline history not updated when mapping both and .
Solution: Consider the command typed when in Cmdline mode and there is
no pending input.
fixes: #2771
related: neovim/neovim#36256
Although the existing behavior technically does match documentation, the
"completely come from mappings" part is a bit ambiguous, because one may
argue that the command doesn't completely come from mappings as long as
the user has typed a key in Cmdline mode. I'm not entirely sure if this
change will cause problems, but it seems unlikely.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18607
Commit Summary
- 6eab2a9 Cmdline history not updated when mapping both <Up> and <CR>
File Changes
(3 files)
- M runtime/doc/cmdline.txt (6)
- M src/ex_getln.c (6)
- M src/testdir/test_cmdline.vim (36)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq pushed 1 commit.
- f60a7b4 Cmdline history not updated when mapping both <Up> and <CR>
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq commented on this pull request.
> +- Only commands that are typed are remembered. A command coming completely + from a mapping is not put in the history.
This also matches :h ": better:
The command-line is only stored in this register when at least
one character of it was typed. Thus it remains unchanged if
the command was completely from a mapping.
There it says "a mapping" instead of "mappings".
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
