Commit: patch 9.2.1117: tests: test_clientserver fails on a pure X11 display

2 views
Skip to first unread message

Christian Brabandt

unread,
Sep 17, 2026, 3:30:15 PM (2 days ago) Sep 17
to vim...@googlegroups.com
patch 9.2.1117: tests: test_clientserver fails on a pure X11 display

Commit: https://github.com/vim/vim/commit/0133a3856678035af26b7a6b9ac333301cfc04ad
Author: dyingc <dyi...@hotmail.com>
Date: Thu Sep 17 19:08:30 2026 +0000

patch 9.2.1117: tests: test_clientserver fails on a pure X11 display

Problem: Test_clientserver_x11_registry_loose_name() fails on X11
because it tries to assert that "remote-send" succeeds, while
the test tries to ensure it fails (after v9.2.1113).
Solution: Drop the assertion (dyingc).

Test_clientserver_x11_registry_loose_name() asserts that its
"--remote-send" succeeds, but that send failing is the point of
the test: the registry entry it writes has a window id that does
not parse, so Vim reports E247 and exits with 1. The assertion
therefore fails wherever the test actually runs. CI never runs
it -- every X11 test in the file is skipped there, since
CheckX11() refuses to run when $WAYLAND_DISPLAY is set and the
Linux workflows set it.

closes: #21333

Signed-off-by: dyingc <dyi...@hotmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_clientserver.vim b/src/testdir/test_clientserver.vim
index f6190ae5c..977c76cc7 100644
--- a/src/testdir/test_clientserver.vim
+++ b/src/testdir/test_clientserver.vim
@@ -278,7 +278,6 @@ func Test_clientserver_x11_registry_loose_name()
" Loose match: "XVIMTESTREG" against a registered "XVIMTESTREG1" whose
" window id is not hex.
call system(cmd .. ' --servername ' .. name .. ' --remote-send x')
- call assert_equal(0, v:shell_error)

call system('xprop -root -remove VimRegistry')
call job_stop(job, 'kill')
diff --git a/src/version.c b/src/version.c
index a1e5d4750..5a863b280 100644
--- a/src/version.c
+++ b/src/version.c
@@ -763,6 +763,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1117,
/**/
1116,
/**/
Reply all
Reply to author
Forward
0 new messages