[vim/vim] Fix Typos (#5532)

13 views
Skip to first unread message

Emir Sarı

unread,
Jan 25, 2020, 3:09:40 PM1/25/20
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5532

Commit Summary

  • Fix Typos

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Emir Sarı

unread,
Jan 25, 2020, 3:19:45 PM1/25/20
to vim/vim, Push

@bitigchi pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Codecov

unread,
Jan 25, 2020, 4:07:47 PM1/25/20
to vim/vim, Subscribed

Codecov Report

Merging #5532 into master will decrease coverage by 1.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #5532      +/-   ##

==========================================

- Coverage      83%   81.73%   -1.27%     

==========================================

  Files         134      130       -4     

  Lines      147991   140686    -7305     

==========================================

- Hits       122837   114994    -7843     

- Misses      25154    25692     +538
Impacted Files Coverage Δ
src/quickfix.c 94.59% <ø> (-0.56%) ⬇️
src/buffer.c 82.42% <ø> (-3.22%) ⬇️
src/term.c 79.96% <ø> (-1.42%) ⬇️
src/evalvars.c 85.57% <ø> (-1.23%) ⬇️
src/xxd/xxd.c 74.72% <ø> (-0.08%) ⬇️
src/os_unix.c 59.3% <ø> (-4.11%) ⬇️
src/normal.c 82.65% <ø> (-0.91%) ⬇️
src/charset.c 86.98% <ø> (-1.32%) ⬇️
src/ex_docmd.c 83.03% <ø> (-0.92%) ⬇️
src/gui.c 56.42% <ø> (-7.21%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9215b...2964a11. Read the comment docs.

Gary Johnson

unread,
Jan 25, 2020, 5:38:19 PM1/25/20
to reply+ACY5DGFUQ3VWTXCELE...@reply.github.com, vim...@googlegroups.com
On 2020-01-25, Emir Sarı wrote:
> -------------------------------------------------------------------------------
>
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/vim/vim/pull/5532
>
> Commit Summary
>
> • Fix Typos

> Patch Links:
>
> • https://github.com/vim/vim/pull/5532.patch
> • https://github.com/vim/vim/pull/5532.diff

A few corrections to your corrections:

> diff --git a/src/buffer.c b/src/buffer.c
> index f56ff0b6259..28bbab4d115 100644
> --- a/src/buffer.c
> +++ b/src/buffer.c
> @@ -1690,7 +1690,7 @@ set_curbuf(buf_T *buf, int action)
> set_bufref(&prevbufref, prevbuf);
> set_bufref(&newbufref, buf);
>
> - // Autocommands may delete the curren buffer and/or the buffer we wan to go
> + // Autocommands may delete the curren buffer and/or the buffer we want to go

+ // Autocommands may delete the current buffer and/or the buffer we want to go

> // to. In those cases don't close the buffer.
> if (!apply_autocmds(EVENT_BUFLEAVE, NULL, NULL, FALSE, curbuf)
> || (bufref_valid(&prevbufref)

> diff --git a/src/getchar.c b/src/getchar.c
> index 72ddbb9ad3a..387938604a0 100644
> --- a/src/getchar.c
> +++ b/src/getchar.c
> @@ -3237,7 +3237,7 @@ vgetorpeek(int advance)
> * 1. a scriptfile
> * 2. the keyboard
> *
> - * As much characters as we can get (upto 'maxlen') are put in "buf" and
> + * As much characters as we can get (up to 'maxlen') are put in "buf" and

+ * As many characters as we can get (up to 'maxlen') are put in "buf" and

> * NUL terminated (buffer length must be 'maxlen' + 1).
> * Minimum for "maxlen" is 3!!!!
> *
> diff --git a/src/gui.c b/src/gui.c
> index 1249fab2209..6eb34b797e1 100644
> --- a/src/gui.c
> +++ b/src/gui.c
> @@ -3419,7 +3419,7 @@ gui_init_which_components(char_u *oldval UNUSED)
> if (oldval != NULL && gui.in_use)
> {
> /*
> - * Check if the menu's go from grey to non-grey or vise versa.
> + * Check if the menu's go from grey to non-grey or vice versa.

+ * Check if the menus go from grey to non-grey or vice versa.

> */
> grey_old = (vim_strchr(oldval, GO_GREY) != NULL);
> grey_new = (vim_strchr(p_go, GO_GREY) != NULL);
> diff --git a/src/gui_mac.c b/src/gui_mac.c
> index 3dfb939e29d..0a4a35b1f01 100644
> --- a/src/gui_mac.c
> +++ b/src/gui_mac.c
> @@ -2919,7 +2919,7 @@ gui_mch_prepare(int *argc, char **argv)
>
> (void)FSGetCatalogInfo(&applFSRef, kFSCatInfoNone, NULL, NULL, &applDir, NULL);
>
> - // This technic return NIL when we disallow_gui
> + // This technique return NIL when we disallow_gui

+ // This technique returns NIL when we disallow_gui

> # endif
> exe_name = FullPathFromFSSpec_save(applDir);
> #endif

Regards,
Gary

vim-dev ML

unread,
Jan 25, 2020, 5:38:46 PM1/25/20
to vim/vim, vim-dev ML, Your activity
On 2020-01-25, Emir Sarı wrote:
> -------------------------------------------------------------------------------
>
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/vim/vim/pull/5532
>
> Commit Summary
>
> • Fix Typos

> Patch Links:
>
> • https://github.com/vim/vim/pull/5532.patch
> • https://github.com/vim/vim/pull/5532.diff

Emir Sarı

unread,
Jan 26, 2020, 3:21:44 AM1/26/20
to vim/vim, vim-dev ML, Push

@bitigchi pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Emir Sarı

unread,
Jan 26, 2020, 3:22:04 AM1/26/20
to vim/vim, vim-dev ML, Comment

Thank you for noticing. All fixed.

—
You are receiving this because you commented.

Bram Moolenaar

unread,
Jan 26, 2020, 4:00:40 PM1/26/20
to vim/vim, vim-dev ML, Comment

Closed #5532 via 4b96df5.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages