[vim/vim] xxd: use %lu for unsigned long in decimal offset output (PR #20055)
mattn
The decimal offset (-d) used %ld with an unsigned long value, so offsets above LONG_MAX were printed as negative numbers. Use %lu instead.
$ printf 'AB' | ./xxd -d -o 9223372036854775808
-9223372036854775808: 4142 AB
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20055
Commit Summary
- 1e202b1 ues %lu for unsigned long
File Changes
(1 file)
- M src/xxd/xxd.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20055)can you add a test for this please?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 45c467f fix test
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#20055)CI failure was caused by the test itself being wrong: Test_xxd_buffer_overflow() expected -9223372036854775808: in the address field, which was a side effect of the original %ld-on-unsigned long bug. The address field must be unsigned (consistent with the hex %lx default), so I've updated the expected value to 9223372036854775808:.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.