[vim/vim] runtime(netrw): Fixing global variable initialization on Windows (PR #19287)
MiguelBarro
Some default options are initialized as empty:
https://github.com/vim/vim/blob/371583642a5eecc134d285e6df49f5edceeab95c/runtime/pack/dist/opt/netrw/autoload/netrw.vim#L69-L73
preventing them later from getting the rigth value:
https://github.com/vim/vim/blob/371583642a5eecc134d285e6df49f5edceeab95c/runtime/pack/dist/opt/netrw/autoload/netrw.vim#L295-L301
because s:NetrwInit() will only set values for undefined variables:
https://github.com/vim/vim/blob/371583642a5eecc134d285e6df49f5edceeab95c/runtime/pack/dist/opt/netrw/autoload/netrw.vim#L53-L57
After the fix, things were not working so I revamp those functions where the default options were used. Besides:
- Copying several files with a single command is not possible on Windows and was broken.
- The code ignored issues associated with the
shellslashoption.
I extended the netrw testing accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19287
Commit Summary
- 4d549bb test: check local filesystem commands operation
- 613e656 fix: proper filesystem commands initialization for Windows
File Changes
(3 files)
- M runtime/pack/dist/opt/netrw/autoload/netrw.vim (239)
- M runtime/pack/dist/opt/netrw/autoload/netrw/fs.vim (3)
- M src/testdir/test_plugin_netrw.vim (454)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
MiguelBarro
@MiguelBarro pushed 1 commit.
- c258a4b fix: proper filesystem commands initialization for Windows
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.