Yegappan Lakshmanan

unread,

Dec 31, 2021, 4:43:22 PM12/31/21

to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/9446

Commit Summary

4fb0c6f Try enabling ASAN for MSVC builds on MS-Windows in Github actions

File Changes

(2 files)

M .github/workflows/ci.yml (2)
M src/errors.h (5)

Patch Links:

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,

Dec 31, 2021, 4:51:11 PM12/31/21

to vim/vim, Subscribed

Codecov Report

Merging #9446 (4fb0c6f) into master (f1474d8) will decrease coverage by 2.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master    #9446      +/-   ##

==========================================

- Coverage   90.36%   87.87%   -2.50%     

==========================================

  Files         154      152       -2     

  Lines      173501   172199    -1302     

==========================================

- Hits       156785   151317    -5468     

- Misses      16716    20882    +4166

Flag	Coverage Δ
huge-clang-none	`89.37% <ø> (-0.02%)`	⬇️
huge-gcc-none	`?`
huge-gcc-testgui	`?`
huge-gcc-unittests	`2.44% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/libvterm/src/rect.h	`0.00% <0.00%> (-96.56%)`	⬇️
src/libvterm/src/state.c	`40.00% <0.00%> (-49.30%)`	⬇️
src/libvterm/src/keyboard.c	`48.42% <0.00%> (-40.00%)`	⬇️
src/libvterm/include/vterm.h	`0.00% <0.00%> (-37.50%)`	⬇️
src/libvterm/src/pen.c	`47.78% <0.00%> (-36.88%)`	⬇️
src/libvterm/src/parser.c	`67.08% <0.00%> (-28.75%)`	⬇️
src/libvterm/src/encoding.c	`44.55% <0.00%> (-28.72%)`	⬇️
src/if_perl.xs	`63.30% <0.00%> (-27.63%)`	⬇️
src/libvterm/src/vterm.c	`47.03% <0.00%> (-19.04%)`	⬇️
src/arabic.c	`86.95% <0.00%> (-8.70%)`	⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1474d8...4fb0c6f. Read the comment docs.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

James McCoy

unread,

Dec 31, 2021, 5:18:21 PM12/31/21

to vim/vim, Subscribed

@yegappan how do you see what failed when there's an ASAN issue on Windows? When I looked into this, it only produced a minidump that had to be debugged, rather than writing a stacktrace to a log file like on Linux.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Dec 31, 2021, 5:58:36 PM12/31/21

to vim_dev, reply+ACY5DGFBOFP3AJCSLK...@reply.github.com, vim/vim, Subscribed

Hi,

On Fri, Dec 31, 2021 at 2:18 PM James McCoy <vim-dev...@256bit.org> wrote:

@yegappan how do you see what failed when there's an ASAN issue on Windows? When I looked into this, it only produced a minidump that had to be debugged, rather than writing a stacktrace to a log file like on Linux.

The MSVC ASAN build on MS-Windows does produce a stack trace just like on Linux.

I am able to redirect the ASAN backtrace to a log file.

Regards,

Yegappan

vim-dev ML

unread,

Dec 31, 2021, 5:58:49 PM12/31/21

to vim/vim, vim-dev ML, Your activity

Hi,

On Fri, Dec 31, 2021 at 2:18 PM James McCoy ***@***.***>
wrote:

> @yegappan <https://github.com/yegappan> how do you see what failed when

> there's an ASAN issue on Windows? When I looked into this, it only produced
> a minidump that had to be debugged, rather than writing a stacktrace to a
> log file like on Linux.
>
>
> The MSVC ASAN build on MS-Windows does produce a stack trace just like on
Linux.
I am able to redirect the ASAN backtrace to a log file.

Regards,
Yegappan

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Dec 31, 2021, 8:23:01 PM12/31/21

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

ca866d3 WIP: Display the ASAN logs if present

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Dec 31, 2021, 8:26:05 PM12/31/21

to vim/vim, vim-dev ML, Push

@yegappan pushed 2 commits.

78a8910 Try enabling ASAN for MSVC builds on MS-Windows in Github actions
181807b WIP: Display the ASAN logs if present

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Dec 31, 2021, 8:33:06 PM12/31/21

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

e8fcf1d Change exists to exist

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 10:22:27 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

734ff8f WIP: display the asan log

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 10:29:30 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

75b0d7e WIP: Remove the other windows builds

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 10:48:26 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

7069f88 WIP: Try enabling ASAN for MSVC builds on MS-Windows in Github actions

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 10:59:09 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

11c54b4 Update log_path

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 11:13:11 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 2 commits.

8803f60 WIP: Try enabling ASAN for MSVC builds on MS-Windows in Github actions
770f843 Update log_path

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 1, 2022, 11:49:06 AM1/1/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

b1de401 WIP: check for failure

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jul 25, 2022, 11:26:44 AM7/25/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 2 commits.

78a23e6 WIP: Try enabling ASAN for MSVC builds on MS-Windows in Github actions
068d0eb Update log_path

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

[vim/vim] WIP: Try enabling ASAN for MSVC builds on MS-Windows in Github actions (PR #9446)

Yegappan Lakshmanan

You can view, comment on, or merge this pull request online at:

Commit Summary

File Changes

Patch Links:

codecov[bot]

Codecov Report

James McCoy

Yegappan Lakshmanan

vim-dev ML

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan

Yegappan Lakshmanan