[vim/vim] Add support for in-band window resize events (PR #19596)
Foxe Chen
Alternative to SIGWINCH on Unix: https://gist.github.com/rockorager/e695fb2924d36b2bcf1fff4a3704bd83. It is trivial to implement, and a good amount of terminals support it.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19596
Commit Summary
- 19c20e4 add support for in-band winodw resize events
File Changes
(7 files)
- M src/gui.c (2)
- M src/main.c (4)
- M src/os_unix.c (8)
- M src/proto/os_unix.pro (1)
- M src/proto/term.pro (3)
- M src/term.c (133)
- M src/testdir/test_termcodes.vim (45)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19596)Looking at it now, I don't think +termresponse is needed for synchronized output or this PR, as both do not use termcap. I originally added it because \033[2026;Ps$y would appear on the screen when running Vim in MSYS2. I will create another PR for this if this is the case.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19596)Thanks. Does any terminal already support this?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19596)Thanks. Does any terminal already support this?
ghostty
iTerm2
kitty
foot
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19596)Thanks. So similar to the synchronized output setting, shouldn't we make those terminal settings configurable to allow users to opt-out of this feature just in case? E.g. like we need some t_XX key codes?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19596)Thanks. So similar to the synchronized output setting, shouldn't we make those terminal settings configurable to allow users to opt-out of this feature just in case? E.g. like we need some
t_XXkey codes?
Well Neovim supports this, and they don't have any setting to configure this IIRC. However I suppose we can add a t_ option to let the user disable it (set to an empty string)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- c73fd83 add support for in-band winodw resize events
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- ae56ad1 add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 3fe74f8 add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- aef46d0 add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- a801b6b add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19596)I think this is ready
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 0a1b64a add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 43bcdde add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- fa3769e add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 9091462 add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 26e9c29 add support for in-band winodw resize events
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19596)Thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Linwei
skywind3000 left a comment (vim/vim#19596)—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.