[vim/vim] Refactor gui_gtk4_f.c (PR #20375)
Foxe Chen
Right now gui.drawarea is not a child of gui.formwin, which I think was not intended. Refactor gui_gtk4_f.c to make it more readable, and make gui.drawarea a child of gui.formwin. The formwin is now called VimForm instead of GtkForm, since we shouldn't use the gtk namespace. Additionally, this fixes the left scrollbar appearing over the drawarea.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20375
Commit Summary
- df88f20 refactor gui_gtk4_f.c and drawarea handling
File Changes
(3 files)
- M src/gui_gtk4.c (57)
- M src/gui_gtk4_f.c (381)
- M src/gui_gtk4_f.h (48)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#20375)vim_form_dispose()does not cancel a pending resize idle. Not fatal (the
g_object_ref()keeps the object alive and the callback bails on
gui.drawarea == NULL), and removing the source would leak the held ref, so
the current approach is self-consistent — noting only for completeness.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.