[vim/vim] [noci] Fix heredoc-eval syntax (PR #10365)

8 views
Skip to first unread message

mattn

unread,
May 6, 2022, 9:43:42 AM5/6/22
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/10365

Commit Summary

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365@github.com>

mattn

unread,
May 6, 2022, 9:44:51 AM5/6/22
to vim/vim, Subscribed

@mattn commented on this pull request.


In runtime/syntax/vim.vim:

> @@ -400,7 +400,7 @@ syn match	vimSetMod	contained	"&vim\=\|[!&?<]\|all&"
 " Let: {{{2
 " ===
 syn keyword	vimLet	let	unl[et]	skipwhite nextgroup=vimVar,vimFuncVar,vimLetHereDoc
-VimFoldh syn region vimLetHereDoc	matchgroup=vimLetHereDocStart start='=<<\s\+\%(trim\>\)\=\s*\z(\L\S*\)'	matchgroup=vimLetHereDocStop end='^\s*\z1\s*$'
+VimFoldh syn region vimLetHereDoc	matchgroup=vimLetHereDocStart start='=<<\s\+\%(eval\|trim\>\)\=\s*\z(\L\S*\)'	matchgroup=vimLetHereDocStop end='^\s*\z1\s*$'

Ah, sorry. possibly taken both.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/review/964677477@github.com>

codecov[bot]

unread,
May 6, 2022, 9:52:14 AM5/6/22
to vim/vim, Subscribed

Codecov Report

Merging #10365 (fb34057) into master (f1d63b9) will increase coverage by 1.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master   #10365      +/-   ##

==========================================

+ Coverage   81.00%   82.49%   +1.48%     

==========================================

  Files         161      148      -13     

  Lines      185817   171841   -13976     

  Branches    42004    38852    -3152     

==========================================

- Hits       150530   141767    -8763     

+ Misses      22786    17474    -5312     

- Partials    12501    12600      +99     
Flag Coverage Δ
huge-clang-none 82.49% <ø> (ø)
linux 82.49% <ø> (ø)
mingw-x64-HUGE ?
mingw-x64-HUGE-gui ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/highlight.c 78.57% <0.00%> (-2.58%) ⬇️
src/misc2.c 86.65% <0.00%> (-2.54%) ⬇️
src/time.c 86.93% <0.00%> (-2.38%) ⬇️
src/help.c 80.07% <0.00%> (-2.38%) ⬇️
src/buffer.c 84.08% <0.00%> (-2.36%) ⬇️
src/libvterm/src/screen.c 51.96% <0.00%> (-2.04%) ⬇️
src/session.c 62.92% <0.00%> (-1.95%) ⬇️
src/menu.c 81.02% <0.00%> (-1.87%) ⬇️
src/if_py_both.h 75.18% <0.00%> (-1.76%) ⬇️
src/gui.c 71.18% <0.00%> (-1.75%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d63b9...fb34057. Read the comment docs.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/c1119646127@github.com>

mattn

unread,
May 6, 2022, 9:55:12 AM5/6/22
to vim/vim, Subscribed

@mattn commented on this pull request.


In runtime/syntax/vim.vim:

> @@ -400,7 +400,7 @@ syn match	vimSetMod	contained	"&vim\=\|[!&?<]\|all&"
 " Let: {{{2
 " ===
 syn keyword	vimLet	let	unl[et]	skipwhite nextgroup=vimVar,vimFuncVar,vimLetHereDoc
-VimFoldh syn region vimLetHereDoc	matchgroup=vimLetHereDocStart start='=<<\s\+\%(trim\>\)\=\s*\z(\L\S*\)'	matchgroup=vimLetHereDocStop end='^\s*\z1\s*$'
+VimFoldh syn region vimLetHereDoc	matchgroup=vimLetHereDocStart start='=<<\s\+\%(eval\|trim\>\)\=\s*\z(\L\S*\)'	matchgroup=vimLetHereDocStop end='^\s*\z1\s*$'

This is wrong. Possibly taken both.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/review/964691295@github.com>

mattn

unread,
May 6, 2022, 9:58:23 AM5/6/22
to vim/vim, Push

@mattn pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/push/9813767528@github.com>

dkearns

unread,
Feb 22, 2024, 7:09:58 AMFeb 22
to vim/vim, Subscribed

This was fixed in cfa8f9a


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/c1959323724@github.com>

dkearns

unread,
Feb 22, 2024, 7:09:58 AMFeb 22
to vim/vim, Subscribed

Closed #10365.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10365/issue_event/11890255965@github.com>

Reply all
Reply to author
Forward
0 new messages