[vim/vim] WinEnter autocommand may confuse Vim when closing tabpage (PR #18733)

[Christian Brabandt]

Problem: WinEnter autocommand may confuse Vim when closing tabpage
Solution: Verify that curwin did not change in close_others()

related: #18722

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18733

Commit Summary

• 46f07f7 WinEnter autocommand may confuse Vim when closing tabpage

File Changes

(2 files)

• M src/testdir/test_autocmd.vim (23)
• M src/window.c (6)

Patch Links:

• https://github.com/vim/vim/pull/18733.patch
• https://github.com/vim/vim/pull/18733.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18733@github.com>

[zeertzjq]

@zeertzjq commented on this pull request.

---

In src/window.c:

> @@ -4416,6 +4417,11 @@ close_others(
     for (wp = firstwin; win_valid(wp); wp = nextwp)
     {
 	nextwp = wp->w_next;
+
+	// autocommands messed this one up
+	if (old_curwin != curwin && win_valid(old_curwin))
+	    curwin = old_curwin;

Don't you need to set curbuf = curwin->w_buffer as well?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18733/review/3455797847@github.com>