[vim/vim] Error message with :unlet! and non-existing dictionary item (PR #18734)
Christian Brabandt
Problem: Error message with :unlet! and non-existing dictionary item
Solution: Set GLV_QUIET when using unlet with bang attribute
fixes: #18516
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18734
Commit Summary
- 884cf81 Error message with :unlet! and non-existing dictionary item
File Changes
(2 files)
- M src/evalvars.c (2)
- M src/testdir/test_expr.vim (13)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
> @@ -1114,4 +1114,17 @@ func Test_bitwise_shift()
call assert_equal(64, MultBy2_A()(32))
endfunc
+func Test_unlet_nonexisting_key()
+ let g:base = {}
+ call assert_fails(':unlet g:base["foobar"]', 'E716:')
+
+ try
+ unlet! g:base["foobar"]
+ catch
+ call assert_false(1, "no error when unletting non-existing dict key")
Can you use assert_report() here?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- d625f87 use assert_report()
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -1114,4 +1114,17 @@ func Test_bitwise_shift()
call assert_equal(64, MultBy2_A()(32))
endfunc
+func Test_unlet_nonexisting_key()
+ let g:base = {}
+ call assert_fails(':unlet g:base["foobar"]', 'E716:')
+
+ try
+ unlet! g:base["foobar"]
+ catch
+ call assert_false(1, "no error when unletting non-existing dict key")
done
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq commented on this pull request.
> +func Test_unlet_nonexisting_key()
+ let g:base = {}
+ call assert_fails(':unlet g:base["foobar"]', 'E716:')
+
+ try
+ unlet! g:base["foobar"]
+ catch
+ call assert_report("error when unletting non-existing dict key")
+ endtry
+ unlet g:base
+
+endfunc
Will it be better to put this test in test_unlet.vim or test_listdict.vim?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.