[vim/vim] fix memory leaks on allocation-failure paths (PR #20745)
mattn
Several functions leaked a freshly allocated object on an allocation-failure path: they ignored the return of list_append_dict() / dict_add_list() / dict_add_dict() (leaking the GC-linked dict or list on OOM), returned past a cleanup label, or dropped a string copy when a grow failed. Each now frees the object on the failure path.
Affected: getqflist, getreginfo, taglist/gettagstack, hlget, prop_list, getmatches, menu_getinfo, popup_getoptions, sign_getplaced, job_info, term_getcursor/term_scrape, diff(), complete_info, cmdcomplete_info, two Vim9 compile paths (constant string concat and ga_add_string), and call_func generic type args.
related: #20668
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20745
Commit Summary
- 1bc6e7a getqflist: free dict on list_append_dict() failure
- a2bfbf9 vim9: free left string when constant string concat alloc fails
- ae6185c vim9: free line copy when ga_add_string() fails
- 2742440 call_func: free generic type args table on name alloc failure
- 29db5fd getreginfo: free regcontents list when dict_add_list() fails
- 4930ea9 builtins: free dict/list when append/add fails on alloc
- 00148e4 taglist/gettagstack: free dict on list_append_dict() failure
File Changes
(18 files)
- M src/cmdexpand.c (2)
- M src/diff.c (3)
- M src/evalfunc.c (3)
- M src/highlight.c (4)
- M src/insexpand.c (7)
- M src/job.c (6)
- M src/match.c (6)
- M src/menu.c (12)
- M src/popupwin.c (36)
- M src/quickfix.c (3)
- M src/register.c (6)
- M src/sign.c (20)
- M src/tag.c (11)
- M src/terminal.c (9)
- M src/textprop.c (3)
- M src/userfunc.c (2)
- M src/vim9compile.c (3)
- M src/vim9expr.c (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.