[vim/vim] syntax/rc.vim has colors that doesn't play well with :colo (Issue #9542)

[Maxim Kim]

Steps to reproduce

1. gvim -Nu NONE
2. :syntax on
3. :set ft=rc
4. :hi normal guibg=darkgreen -- imagine we have a colorscheme that uses darkgreen as a background.
5. iSTYLE (or open vim.rc from vim project)

Expected behaviour

STYLE is invisible.

There actually a set of colors in syntax/rc.vim that will not work OK for some/many colorschemes:

" Default color overrides

hi def rcLanguage›      term=reverse ctermbg=Red ctermfg=Yellow guibg=Red guifg=Yellow

hi def rcMainObject›    term=underline ctermfg=Blue guifg=Blue

hi def rcSubObject›     ctermfg=Green guifg=Green

hi def rcCaptionParam›  term=underline ctermfg=DarkGreen guifg=Green

hi def rcParam› ctermfg=DarkGreen guifg=DarkGreen

hi def rcStatement›     ctermfg=DarkGreen guifg=DarkGreen

hi def rcCommonAttribute›       ctermfg=Brown guifg=Brown

@chrisbra

Version of Vim

8.2.4103

Environment

win10, Gvim

Logs and stack traces

No response

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9542@github.com>

[Maxim Kim]

Found it out with my colorscheme where for example rcSubObject is barely visible:

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9542/1013899030@github.com>

[Bram Moolenaar]

I think it's a bad idea for a syntax file to define colors. This is very likely to collide with anyone not using standard colors.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9542/1013905500@github.com>

[Christian Brabandt]

Closed #9542 via chrisbra/vim-rc-syntax@af90572.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/9542/issue_event/5900587033@github.com>

[Christian Brabandt]

Please check, if my changes make at least some sense 🤔

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9542/1013918093@github.com>

[Maxim Kim]

@chrisbra yep, much better.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9542/1013920646@github.com>