Commit: patch 9.1.2051: tests: fix Test_cd_completion fails in Appveyor

0 views
Skip to first unread message

Christian Brabandt

unread,
Jan 6, 2026, 5:01:11 AM (4 days ago) Jan 6
to vim...@googlegroups.com
patch 9.1.2051: tests: fix Test_cd_completion fails in Appveyor

Commit: https://github.com/vim/vim/commit/679c2c01faab2b2106ecd7c1038efa031158b93b
Author: Muraoka Taro <koron....@gmail.com>
Date: Mon Jan 5 08:13:18 2026 +0000

patch 9.1.2051: tests: fix Test_cd_completion fails in Appveyor

Problem: Test_cd_completion test fails in Appveyor. In Appveyor, a path
containing spaces was selected as the test target. But the
comparison failed because spaces were not taken into account
(after v9.1.2050)
Solution: Escape spaces in paths for comparison (Muraoka Taro)

closes: #19087

Signed-off-by: Muraoka Taro <koron....@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_cd.vim b/src/testdir/test_cd.vim
index 115688225..6248ee484 100644
--- a/src/testdir/test_cd.vim
+++ b/src/testdir/test_cd.vim
@@ -261,22 +261,28 @@ func Test_cd_completion()
let drive = full[0]
call chdir(saved_cwd)

+ " Spaces are escaped in command line completion. Next, in assert_match(),
+ " the backslash added by the first escape also needs to be escaped
+ " separately, so the escape is doubled.
+ let want_full = escape(escape(full, ' '), '\')
+ let want_dir = escape(escape(dir, ' '), '\')
+
for cmd in ['cd', 'chdir', 'lcd', 'lchdir', 'tcd', 'tchdir']
for sep in [ '/', '\']

" Explicit drive letter
call feedkeys(':' .. cmd .. ' ' .. drive .. ':' .. sep ..
\ partial .. "\<C-A>\<C-B>\"\<CR>", 'tx')
- call assert_match(full, @:)
+ call assert_match(want_full, @:)

" Implicit drive letter
call feedkeys(':' .. cmd .. ' ' .. sep .. partial .. "\<C-A>\<C-B>\"\<CR>", 'tx')
- call assert_match('/' .. dir .. '/', @:)
+ call assert_match('/' .. want_dir .. '/', @:)

" UNC path
call feedkeys(':' .. cmd .. ' ' .. sep .. sep .. $COMPUTERNAME .. sep ..
\ drive .. '$' .. sep .. partial .."\<C-A>\<C-B>\"\<CR>", 'tx')
- call assert_match('//' .. $COMPUTERNAME .. '/' .. drive .. '$/' .. dir .. '/' , @:)
+ call assert_match('//' .. $COMPUTERNAME .. '/' .. drive .. '$/' .. want_dir .. '/' , @:)

endfor
endfor
diff --git a/src/version.c b/src/version.c
index b724308b5..ce0ef75de 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 2051,
/**/
2050,
/**/
Reply all
Reply to author
Forward
0 new messages