[vim/vim] Fix netrw plugin issue using powershell (PR #10931)

31 views
Skip to first unread message

MiguelBarro

unread,
Aug 17, 2022, 4:44:51β€―AM8/17/22
to vim/vim, Subscribed

Vim\vim82\autoload\netrw.vim plugin has issues with powershell because the function s:NetrwExe falls back to cmd on windows. This is used for example to call curl.

netrw.vim uses vim's shellescape() to decorate urls and is witty enough to use single quotes to escape if powershell is detected ('http://whatever' for example). Uses it through s:ShellEscape().

curl doesn't admit single quoted arguments from cmd and breaks. But it works on powershell because it will remove them for the call.

You can view, comment on, or merge this pull request online at:

Β Β https://github.com/vim/vim/pull/10931

Commit Summary

  • e8d3063 Make curl calls powershell friendly

File Changes

(1Β file)

Patch Links:

β€”
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931@github.com>

cecamp

unread,
Aug 17, 2022, 11:07:52β€―AM8/17/22
to vim/vim, Subscribed

Would you please send me a patch? (look at the top of syntax/netrw.vim for email addr)

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/c1218137705@github.com>

MiguelBarro

unread,
Aug 17, 2022, 11:31:48β€―AM8/17/22
to vim/vim, Subscribed

Closed #10931.

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/issue_event/7207106777@github.com>

MiguelBarro

unread,
Aug 17, 2022, 11:31:48β€―AM8/17/22
to vim/vim, Subscribed

Thanks for the prompt answer. Sent ... I guess the pull request doesn't make sense anymore.

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/c1218168428@github.com>

MiguelBarro

unread,
Aug 18, 2022, 2:14:10β€―AM8/18/22
to vim/vim, Subscribed

Reopened #10931.

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/issue_event/7211310496@github.com>

MiguelBarro

unread,
Aug 18, 2022, 2:16:33β€―AM8/18/22
to vim/vim, Subscribed

Unfortunately, it seems to be something wrong with the mail (DNS complains the domain doesn't exist anymore).
Somebody can hint the good one?

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/c1219079771@github.com>

Christian Brabandt

unread,
Aug 18, 2022, 2:27:51β€―AM8/18/22
to vim/vim, Subscribed

did you remove the capital letters? the domain should be IIRC @drchip.org

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/c1219086507@github.com>

MiguelBarro

unread,
Aug 18, 2022, 3:15:43β€―AM8/18/22
to vim/vim, Subscribed

My fault. I misspelled the domain. Now it seems to be delivered. Thanks @chrisbra πŸ™‡β€β™‚οΈ

β€”
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/c1219120915@github.com>

MiguelBarro

unread,
Aug 18, 2022, 3:15:44β€―AM8/18/22
to vim/vim, Subscribed

Closed #10931.

β€”
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10931/issue_event/7211669084@github.com>

Reply all
Reply to author
Forward
0 new messages