[vim/vim] [WIP] win32: Refactor the NSIS installer (#3501)
K.Takata
After the discussion in #3485, I have created a new NSIS installer.
The appearance is based on @gpwen's work and also uses MUI2, but the rest of the code is based on the original (non-MUI2) NSIS script and this still relies on dosinst.c. So we don't need to maintain duplicated codes.
The items I listed at #3485 (comment) are all implemented.
And also:
- Most of the message boxes were removed like gpwen's.
- The command prompt will not be shown. (
nsExec::Execis used instead ofExecWait.) - Uninstallation of the old version will be started after selecting the install location. (same as gpwen's)
- The installer now remembers the selections of the user for generating
_vimrc. (Key remap and mouse behavior.) - Unicode mode is turned on for future translation. This requires NSIS 3.0.
(gpwen's translation uses each encoding for each language. This uses UTF-8 (with BOM) for all languages.)
You can download an installer from here:
https://ci.appveyor.com/project/k-takata/vim-win32-installer/build/job/jod0d3d3y9fvet3y/artifacts
(No need to care about the CI status. It's just failed to push the result to GitHub releases.)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/3501
Commit Summary
- installer: Use LogicLib
- nsis: Skip if libgcc_s_sjlj-1.dll doesn't exist
- nsis: Respect NLS setting for GvimExt
- nsis: Register "EstimatedSize"
- nsis: Adjust some settings
- dosinst: Register some more information in installer
- dosinst: Adjust the default _vimrc
- nsis: Use nsExec::Exec instead of ExecWait
- nsis: Use MUI2
- nsis: Use InstallLib for installing DLLs
File Changes
- M nsis/gvim.nsi (720)
- A nsis/icons/header.bmp (0)
- A nsis/icons/header.svg (265)
- A nsis/icons/un_header.bmp (0)
- A nsis/icons/uninstall.bmp (0)
- M nsis/icons/vim_16c.ico (0)
- M nsis/icons/vim_uninst_16c.ico (0)
- A nsis/icons/welcome.bmp (0)
- A nsis/icons/welcome.svg (268)
- A nsis/lang/english.nsi (235)
- M src/dosinst.c (29)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
K.Takata
Screen shots (Installer):
-
Welcome
-
License
-
Choose components
If this is the first time installation:
If an older version of Vim has been already installed, another checkbox for uninstalling will be shown:
-
Choose _vimrc setting
-
Install location
-
Installing
If an older version of Vim has been already installed, the uninstaller will be started before this. If it is uninstalled, then it will back to this screen.
-
Finish
Codecov
Codecov Report
Merging #3501 into master will decrease coverage by
0.03%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #3501 +/- ## ========================================== - Coverage 77.13% 77.1% -0.04% ========================================== Files 99 99 Lines 138985 138985 ========================================== - Hits 107211 107166 -45 - Misses 31774 31819 +45
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/gui_beval.c | 55.02% <0%> (-6.99%) |
⬇️ |
| src/gui_gtk_x11.c | 48.01% <0%> (-0.64%) |
⬇️ |
| src/window.c | 83% <0%> (-0.52%) |
⬇️ |
| src/if_xcmdsrv.c | 84.17% <0%> (-0.36%) |
⬇️ |
| src/diff.c | 77.01% <0%> (-0.14%) |
⬇️ |
| src/mbyte.c | 62.29% <0%> (-0.13%) |
⬇️ |
| src/channel.c | 83.13% <0%> (-0.04%) |
⬇️ |
| src/screen.c | 78.71% <0%> (-0.03%) |
⬇️ |
| src/eval.c | 82.63% <0%> (+0.04%) |
⬆️ |
| src/gui.c | 57.54% <0%> (+0.05%) |
⬆️ |
| ... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 6dff58f...92f8e62. Read the comment docs.
K.Takata
Screen shots (Uninstaller):
-
Start
-
Choose components
Now I removed the message boxes while uninstalling and this screen is shown instead.
(The last two checkboxes might be better to be off by default? Not sure.)
-
Uninstalling
-
Finish
scootergrisen
I suggest having the two "default" option in the same style.
Maybe delete the "default" part because if the radio button is selected as default then maybe not nessary to write default because its already selected as default.
Maybe change "mouse behaviour" to "mouse button behavior".
That way you can remove "button" from the following text and have it shorter.
"Right: context menu, left: visual mode"
K.Takata
Maybe delete the "default" part because if the radio button is selected as default then maybe not nessary to write default because its already selected as default.
I don't agree this. As I wrote above, the new installer remember the selection of a user. When the user execute the new installer next time, the selected button might not be the default setting.
K.Takata
@k-takata pushed 6 commits.
- d8832f1 nsis: Support translation
- e8554ff nsis: Add workarounds for Japanese NSIS messages
- 92c89c6 nsis: Fix some !ifdef conditions
- 1e7f6ec nsis: Fix installer directory
- a6802fa nsis: Remove old codes
- b204f71 nsis: Disable VisVim by default
—
You are receiving this because you are subscribed to this thread.
K.Takata
Now translations are avaliable.
Also fixed some minor bugs.
K.Takata
You can download the updated installer from here:
https://github.com/k-takata/vim-win32-installer/releases/tag/v8.1.0443-newinstaller2
h_east
2018-10-2(Tue) 17:37:16 UTC+9 K.Takata:
>
> https://github.com/k-takata/vim-win32-installer/releases/tag/v8.1.0443-newinstaller2
I thought it would be better if the 64 bit version could be installed with the installer.
I know that Mr. Bram is not enthusiastic for the 64bit Vim installer :)
--
Best regards,
Hirohito Higashi (h_east)
K.Takata
@k-takata pushed 3 commits.
—
You are receiving this because you are subscribed to this thread.
scootergrisen
Cool 😸
If the key remapping is always going to be a 2 choice option would it not be better to have it as a check box with the text "Remap a few keys for Windows behavior..."?
Simpler, shorter, less text to read/understand.
K.Takata
If the key remapping is always going to be a 2 choice option would it not be better to have it as a check box with the text "Remap a few keys for Windows behavior..."?
That might be an option. Then we might be able to create another option to select sourcing defaults.vim or vimrc_example.vim. Currently, dosinst.c accepts the selection only when executed with the interactive mode. It doesn't have a command line option for that.
K.Takata
@brammool Thank you for adding this to the todo.txt:
Patch to simplify nsis installer. (Ken Takata, 2018 Sep 24, was #3479)
Now included in #3501, using MUI2.
Improve the installer for MS-Windows. There are a few alternatives:
- mui2 installer improved by Ken Takata (2018 Sep 29)
BTW, now I'm thinking to create the both types of installers in our vim-win32-installer nightly builds.
It can make casual users to try the new installer easily. (Of course, we should state that the installer is experimental.)
What do you think of this?
Christian Brabandt
BTW, now I'm thinking to create the both types of installers in our vim-win32-installer nightly builds.
It can make casual users to try the new installer easily. (Of course, we should state that the installer is experimental.)
What do you think of this?
I like that and I think that would get the feature a good test base. In fact, I actually wanted to suggest just that the other day, but forgot about it :(
K.Takata
Rebased and changed the _vimrc setting dialogbox.
Now a user can select vi compatibility: 'cp', 'nocp', sourcing defaults.vim or sourcing vimrc_example.vim.
K.Takata
The updated installer is here:
https://github.com/k-takata/vim-win32-installer/releases/tag/v8.1.0451-newinstaller
K.Takata
@chrisbra
I created a PR for it: vim/vim-win32-installer#74.
scootergrisen
I think it looks to overwhelming for a new user to see all those options/all that text.
It can look alot simpler if use drop downs.
Instead of all those "default" we could have a "Reset" button.
Also the to titles beginning with "Choose..." basically says the same.
K.Takata
I think it looks to overwhelming for a new user to see all those options/all that text.
Agree.
Instead of all those "default" we could have a "Reset" button.
Adding it seems very difficult.
This is the updated screen shot.
K.Takata
The updated installer is here:
https://github.com/k-takata/vim-win32-installer/releases/tag/v8.1.0451-newinstaller2
scootergrisen
You are writing the same things multiple times which does not help the user.
"Choose _vimrv settings" "Choose the settings" "Vi Compatibility" "Compatibility and enhancements" "Vim with all enhancements" "right and left buttons" "Right: ... Left:".
The 3 areas could be as short as "Compatibility", "Keyboard", "Mouse".
At least the "(Default)" is now consistent.
The "Compatibility and enhancements" could have a "newline" at the end so all 3 areas are using the same style.
If someone can remember another software that uses NSIS with a reset button then we could see how they have done it. I can remember any at the moment but will try and look for it.
Or generally see how other software for Windows does it.
K.Takata
So, can you propose concrete messages?
Right button
left button [popup menu, starts visual]
I don't agree with this part in your screen shot.
It's very hard to under stand that "Right button" corresponds to "popup menu" and "left button" corresponds to "start visual".
scootergrisen
Not sure what the best way would be so its short but not cryptic.
Maybe use "/" to seperate left/right.
I think the right click menu is called context menu and not popup menu.
It would be more logical to have the left button info to the left and the right button info to the right.
Button behavior (left/right):
Visual mode/context menu
Select mode/context menu
Visual mode/extend selection
Left/right button behavior:
Visual mode/context menu
Select mode/context menu
Visual mode/extend selection
Sometimes in other software i see they go crazy with spaces and big letters in the english source but i dont know if its correct english or they do it to make it easy to read or something.
Maybe some good at english knows more.
Button behavior (Left / Right):
Visual mode / Context menu
Select mode / Context menu
Visual mode / Extend selection
Maybe other can give input of what they thing of the examples.
Vim Github Bot
I like the last shown dialog. I don't think the Mouse behaviour description should be shortened as mentioned. This looks too confusing.
I would call those three sections perhaps "Vi Mode" (instead of Vi Compatibility), not sure of a better short name, "Mappings" (instead of Key remapping for Windows behaviour which is too long) and "Mouse" (instead of Mouse behaviour)
Vim Github Bot
@chrisbra Your most recent post in this thread got sent to the vim-dev list as being from "Vim Github Bot" instead of as being from Christian Brabant.
Vim Github Bot
OT: @chdiza yes correct. I changed the sender because I thought it looks a bit better. I don't know how to get the actual sender from the message that is created initially so (might have a look later at this)
Vim Github Bot
The first drop down currently have "(Default)" as the last item.
I suggest perhaps having them all the first item in the each list.
Not sure if "Vi Mode" or "Vi Compatibility" ir correct but i suggest using whatever is using in Vim.
vim --help says something about Vi mode and Ex mode and Improved Ex mode so if that is what its talking about then i suggest using the same text (mode) so its the same.
Also i was thinking if <C-V> etc should be <Ctrl-V>.
As new Vim user i did not know what C is but im guess its Ctrl.
It seems Vim is using CTRL in :help
Maybe it could be written a better way instead of listing all those <C-*>.
But i dont know the details.
Vim Github Bot
Is the installer using the old icons again where white is transparent?
Can you check the icons.
Vim Github Bot
@chdiza (changed it a bit more). Let's see if the result in the vim-dev list is better now.
chrisbra via Vim Github Bot
@chdiza (changed it a bit more). Let's see if the result in the vim-dev list is better now.
And if it did not forget to save the rewrite script, it should actually work.
(sorry for spamming this issue)
chdiza via Github
Let's see if the result in the vim-dev list is better now.
Yes, it's back to normal. The inbox now lists "Christian Brabant" as the sender.
chdiza via Github
Yes, it's back to normal. The inbox now lists "Christian Brabant" as the sender.
No wait, I'm wrong. It looks right when GitHub sends it directly to me, but wrong when I'm looking at the inbox of the account that receives the ML. It now says "chrisbra via Vim Github", instead of what it should say (and used to say), namely your full name.
k-takata via Github
Is the installer using the old icons again where white is transparent?
You are right. I wasn't aware that the icons were updated recently. Fixed.
—
You are receiving this because you are subscribed to this thread.
k-takata via Github
Okay all, how about this?
"Vi Mode" (instead of Vi Compatibility)
The word "mode" reminds me a different thing: normal mode, insert mode, etc.
How about "Vi / Vim behavior"?
"Mappings" (instead of Key remapping for Windows behaviour which is too long) and "Mouse" (instead of Mouse behaviour)
Agree.
Also i was thinking if
<C-V>etc should be<Ctrl-V>.
I was afraid that using <Ctrl-V> makes the message too long, but using Ctrl-V doesn't make it so long.
k-takata via Github
The first drop down currently have "(Default)" as the last item.
I suggest perhaps having them all the first item in the each list.
The first drop down is sorted in the order of the enhancements. The last one is most enhanced.
Other lists don't have much meaning in their orders.
k-takata via Github
Updated the patches to make the uninstaller more precise.
—
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chdiza okay reverted back to the old behaviour. If anybody feels differently, please open a new ticket, so we don't spam unrelated issues.
Christian Brabandt
@k-takata looks really nice now.
K.Takata
Hi all,
The new MUI2 installer is now available at vim-win32-installer:
https://github.com/vim/vim-win32-installer/releases/tag/v8.1.0454
Please try gvim_8.1.****_x86-mui2.exe.
K.Takata
@brammool I'm now thinking adding support for 64-bit installer, because there are some requests for that. (E.g. vim/vim-win32-installer#73)
But I have a question about the current NSIS script. It requires some executables have the w32 suffixes. (E.g. installw32.exe, uninstalw32.exe, ...)
Why they are needed? If we remove them, we can use the same script for both 32- and 64-bit installer.
Otherwise, we should add many !ifdefs (or we should also use the w32 suffixes for the 64-bit installer.)
scootergrisen
Its a little confusing the uninstall dialog just pops up at the beginning of the installation progress.
Could the uninstall stuff perhaps be part of the same dialog so there is not two dialogs.
K.Takata
Could the uninstall stuff perhaps be part of the same dialog so there is not two dialogs.
It's not possible (for now).
Actually, gpwen's MUI2 installer does call the uninstaller silently, but it is because his uninstaller is more precise. It deletes the files only installed by the installer. It doesn't delete _vimrc if it is changed by the user.
One possible option is that if the uninstaller is executed silently, do only the first two components: "Unregister Vim" and "Remove Vim Executables/Runtime files". Do not delete vimfiles directory and the root of Vim directory.
K.Takata
Added minimal support for creating 64-bit installer.
It still uses the w32 suffixes even for the 64-bit installer.
—
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Ken Takata wrote:
> @brammool I'm now thinking adding support for 64-bit installer, because there are some requests for that. (E.g. vim/vim-win32-installer#73)
> Otherwise, we should add many !ifdefs (or we should also use the `w32` suffixes for the 64-bit installer.)
other install.exe that can be build. It's possible to use "win" instead
of "w32" if that is clearer. But if there actually are two versions of
the executable, it's probably best to give them different names,
otherwise it's very easy to end up with the wrong one.
--
Living in Hollywood is like living in a bowl of granola. What ain't
fruits and nuts is flakes.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
K.Takata
Bram's comment was not redirected here:
https://groups.google.com/d/msg/vim_dev/TRBJGgCvHik/CEAh1NSGBAAJ
The "w32" addition is to make sure it doesn't get confused with the
other install.exe that can be build. It's possible to use "win" instead
of "w32" if that is clearer. But if there actually are two versions of
the executable, it's probably best to give them different names,
otherwise it's very easy to end up with the wrong one.
We have already dropped support for MS-DOS, so the "w32" (or "win") addition might not be so important now.
And yes, we need the 64-bit version of installer.exe to create 64-bit Vim installer.
But I think keep using "w32" is the simplest way. It doesn't require changing a batch file in vim-win32-installer. I have already done a preparation of 64-bit installer in vim/vim-win32-installer#79 in that way.
K.Takata
https://github.com/vim/vim-win32-installer/releases/tag/v8.1.0466
64-bit installer is now available at vim-win32-installer. (32-bit build seems failed with some reason.)
K.Takata
Improved a message while waiting uninstall of old version.
Confusion might be reduced.
—
You are receiving this because you are subscribed to this thread.
Christian Brabandt
https://github.com/vim/vim-win32-installer/releases/tag/v8.1.0466
64-bit installer is now available at vim-win32-installer. (32-bit build seems failed with some reason.)
Rebuild the commit and this time it was successfull
K.Takata
Could the uninstall stuff perhaps be part of the same dialog so there is not two dialogs.
It's not possible (for now).
I'm rethinking this now.
It's not impossible to run the uninstaller in silent mode at the first step of the installing.
But it's not clear which items should be uninstalled and which should be kept.
Someone may want to just update the version of Vim and want to keep the system _vimrc.
Someone may want to reinstall Vim with changing the settings of the system _vimrc.
Kicking the uninstaller in silent mode cannot handle this situation well...
Should we keep the system _vimrc when the uninstaller in silent mode?
Then if someone wants to change the setting of the system _vimrc, he should run the uninstaller manually and next execute the installer. Is it okay?
(gpwen's uninstaller checks if the system _vimrc is changed or not, but it is not easy in the current system.)
I think that the current implementation is better because it is flexible, even if it is somewhat confusing and a bit noisy.
And even so, it is more silent than the original non-MUI2 installer.
—
You are receiving this because you are subscribed to this thread.
scootergrisen
Maybe look at how other software is doing it.
If i click cancel in the uninstall dialog Vim seems to install anyway.
K.Takata
If i click cancel in the uninstall dialog Vim seems to install anyway.
Good point! The behavior is not changed by my patches.
What will happen when a user cancel the uninstaller?
If gvimext{32,64} is in use, it might not be properly updated.
Any other issues? Maybe no.
Maybe look at how other software is doing it.
Some software ask the user to uninstall the old version before install it.
Some other just overwrite the old version.
scootergrisen
Does both the 32-bit and 64-bit installer use "Program Files (x86)" as default?
I think it should be "Program Files" for 64-bit and "Program Files (x86)" for 32-bit.
More work sorry 🍰
K.Takata
Does both the 32-bit and 64-bit installer use "Program Files (x86)" as default?
No. 64-bit installer use "Program Files" as default, however,if another version of Vim is installed in another directory (e.g. "Program Files (x86)"), it is used as a default.
K.Takata
Could the uninstall stuff perhaps be part of the same dialog so there is not two dialogs.
It's not possible (for now).
I'm rethinking this now.
It turns out that kicking the uninstaller in silent mode is not reliable in this system.
We cannot know when the uninstaller finished.
So my conclusion is still not changed:
I think that the current implementation is better because it is flexible, even if it is somewhat confusing and a bit noisy.
—
You are receiving this because you are subscribed to this thread.
K.Takata
Added some comments to the system _vimrc.
See the latest commit for detail: d1da147
E.g.:
" Vim with all enhancements source $VIMRUNTIME/vimrc_example.vim " Remap a few keys for Windows behavior source $VIMRUNTIME/mswin.vim " Mouse behavior (the Windows way) behave mswin " Use the internal diff if available. " Otherwise use the special 'diffexpr' for Windows. if &diffopt !~# 'internal' set diffexpr=MyDiff() endif
(Wording might be needed to be adjusted.)
—
You are receiving this because you are subscribed to this thread.
K.Takata
Refactored the commits for easier reviewing.
(Some of them are squashed and some others are edited.)
—
You are receiving this because you are subscribed to this thread.
K.Takata
I think I have almost done my work for this.
(If #3525 will be merged before this, I should rebase this upon it, but it might not be a problem.)
If anyone wants to update the translation, please send a PR to the topic/refactor-installer branch in https://github.com/k-takata/vim .
scootergrisen
Guess we need some translation instruction on how to translate the installer.
Do i just make a copy of english.nsi?
Are strings like "Typical", "Minimal", "Full" not already translated in the NSIS translations?
They seem so commonly used.
K.Takata
Do i just make a copy of english.nsi?
I think it's the best way for now. The english.nsi has redundant header compared other files, though.
It is based on gpwen's work, some of the messages are not used for now.
Are strings like "Typical", "Minimal", "Full" not already translated in the NSIS translations?
Yes, they can be translated. See "str_type_typical", "str_type_minimal" and "str_type_full".
scootergrisen
I meant if "Typical", "Minimal", "Full" was already translate in the NSIS translations that comes with NSIS but i guess not.
I dont like that translation strings are wrapping on multiple line so you have:
"text \[newline][space][space][space][space][space]text"
scootergrisen
Maybe just have each translation on one line like https://github.com/qbittorrent/qBittorrent/blob/master/dist/windows/installer-translations/danish.nsi
K.Takata
I just followed the gpwen's way. If you don't like that, blame to him/her.
scootergrisen
I see some leading/trailing spaces i suggest to remove.
LangString str_msg_compat_title ${LANG_ENGLISH} \
" Vi / Vim behavior "
LangString str_msg_keymap_title ${LANG_ENGLISH} \
" Mappings "
LangString str_msg_keymap_default ${LANG_ENGLISH} \
" Do not remap keys (Default)"
LangString str_msg_keymap_windows ${LANG_ENGLISH} \
" Remap a few keys"
LangString str_msg_mouse_title ${LANG_ENGLISH} \
" Mouse "
LangString str_msg_compat_title ${LANG_ENGLISH} \
"Vi / Vim behavior"
LangString str_msg_keymap_title ${LANG_ENGLISH} \
"Mappings"
LangString str_msg_keymap_default ${LANG_ENGLISH} \
"Do not remap keys (Default)"
LangString str_msg_keymap_windows ${LANG_ENGLISH} \
"Remap a few keys"
LangString str_msg_mouse_title ${LANG_ENGLISH} \
"Mouse"
scootergrisen
I see "/" without and with space before/after. Maybe make it consistent whichever is prefered:
"Remove Vim Executables/Runtime Files"
" Vi / Vim behavior "
K.Takata
I intentionally added the spaces. Without the spaces, they look too dense.
If your translation doesn't needs the spaces, you can remove them.
scootergrisen
If you want space before/after a string i think its better to add it in the code.
That way translations can focus on translating the text only.
K.Takata
I don't agree that.
scootergrisen
There are some strings that starts with "Fail to ".
I think they should be "Failed to ".
K.Takata
The strings were copied from the gpwen's work, but currently not used.
K.Takata
I included your Danish translation.
I see some leading/trailing spaces i suggest to remove.
Oops, some of them should have been removed when I changed the radio buttons to the drop down lists.
—
You are receiving this because you are subscribed to this thread.
K.Takata
Rebased on top of 8.1.0472.
K.Takata
@brammool
I think you always get the patch of a PR by adding ".diff" to the end of the URL.
(E.g. https://github.com/vim/vim/pull/3501.diff)
However, I found that this doesn't handle binary files well.
Please use the following zip file for the nsis icon files of this PR.
K.Takata
Or you can use ".patch" instead of ".diff". E.g.
wget https://github.com/vim/vim/pull/3501.patch git apply 3501.patch
The differences are:
- ".patch" can handle binary files, but ".diff" cannot.
- ".patch" includes all commits and commit messages. (e.g. This PR includes nearly 30 commits.)
".diff" just includes the total changes.
Bram Moolenaar
Ken Takata wrote:
> @brammool
> I think you always get the patch of a PR by adding ".diff" to the end of the URL.
> (E.g. https://github.com/vim/vim/pull/3501.diff)
> However, I found that this doesn't handle binary files well.
> Please use the following zip file for the nsis icon files of this PR.
>
Yes, I usually get the .diff file, and that works. I'll check the icons
once we get to including this.
--
hundred-and-one symptoms of being an internet addict:
200. You really believe in the concept of a "paperless" office.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
You are receiving this because you are subscribed to this thread.
Christian Brabandt
I just downloaded https://github.com/vim/vim-win32-installer/releases/download/v8.1.0490/gvim_8.1.0490_x64-mui2.exe and installed it on a windows 10 system.
I really liked the new installer and it worked really well.
K.Takata
@chrisbra Thank you for trying!
You might want to send updated German translations? ;-)
Christian Brabandt
@k-takata
I did not know I am the nsis translator. But here we go: https://gist.github.com/chrisbra/030431f24f6f26ddda559d63e436d67b (hopefully the link finally works after the recent github failure).
2 observations:
- I did not see the VisVim installation dialog (is this obsolete by now? But it is still uncommented in the language file)
- After a second thought, I think the difference between "vi compatible", "Vim original", "Vim with some enhancements" and "Vim with all enhancements" is not entirely clear. The first ones should be clear to users (&cp setting), but not the last two. Perhaps it is better to mention what file it will source, e.g.
"Vim with some enhancements (sourcing defaults.vim)" and "Vim with all enhancements (sourcing vimrc_example.vim)"
Hopefully that is not too long.
K.Takata
- I did not see the VisVim installation dialog
I currently disable it, because it is for VC6 or older versions. Is there anyone still use it?
- After a second thought, I think the difference between "vi compatible", "Vim original", "Vim with some enhancements" and "Vim with all enhancements" is not entirely clear.
Agree.
Hopefully that is not too long.
I had to update the layout. Not sure that the droplists should be left aligned or right aligned.
After applying your translation, the description for the key remapping is too long to display:
Christian Brabandt
thanks for noticing. Does this updated patch fix the issue? It moves some of the description to the title (what is now called Mappings is then called "Mappings to Windows default keys")?
BTW: Is there an easy way to test the translation even when installing on a system with a different locale (or do I have to configure Windows first to use the german system language before trying the installer)?
K.Takata
@k-takata pushed 2 commits.
—
You are receiving this because you are subscribed to this thread.
K.Takata
I applied it. It looks okay now.
I also adjusted English messages.
German:
English:
BTW: Is there an easy way to test the translation even when installing on a system with a different locale (or do I have to configure Windows first to use the german system language before trying the installer)?
Currently, no. I edited the NSIS script.
Should we show a dialogbox to select the language?
—
You are receiving this because you are subscribed to this thread.
Christian Brabandt
thanks looks good. Can you please finally squash this last change in: https://gist.github.com/chrisbra/030431f24f6f26ddda559d63e436d67b/revisions#diff-29679af159aae6c3cd407caf92622041
Should we show a dialogbox to select the language?
Yeah, I think this is the easiest way.
K.Takata
Updated.
Yeah, I think this is the easiest way.
Maybe it is useful for debugging, but is it useful for normal users?