[vim/vim] GTK3 UI has font rendering issues (Issue #21063)

[Mladen Mijatov]

MeanEYE created an issue (vim/vim#21063)

Steps to reproduce

1. Open existing document;
2. Press ciw and retype the same text;
3. Cursor leaves rendering artefacts.

Image: Image (view on web)

Happens regardless of configured colorscheme.

https://github.com/user-attachments/assets/59e25558-153e-4132-b892-b2569a2eec93

Expected behaviour

There shouldn't be any artifacts. When writing this text on a new, empty, line issue doesn't occur, only when replacing text.

Version of Vim

9.2 Included patches: 1-858

Environment

Debian GNU/Linux forky/sid (testing, up to date)
Vim is not ran in terminal or shell so probably irrelevant. Gnome-Shell, latest.

Logs and stack traces

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#21063)

What font did you use? Have you tried a different one? Did you try vim --clean?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5307011009@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

Font is custom build of Iosevka, at size 12. Tried with --clean and problem is not present there. Tried different font with my config and problem persists. Plugins are not to blame it seems, I tried disabling them all and individually. However default theme doesn't have the issue. There seems to be a rendering issue, but it doesn't leave artifacts.

https://github.com/user-attachments/assets/7b844e10-617e-427f-95ca-c8fd3ee63020

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5307078426@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

Okay, found the culprit. It's set guiligatures=!\"#$%&()*+-./:<=>?@[]^_{\|~. When I remove that line everything works. Probably wrong character length calculation.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5307162298@github.com>

[Mao-Yining]

mao-yining left a comment (vim/vim#21063)

@MeanEYE Could you try patch 9.2.0905?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5311154559@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

I'll try to find time and recompile Vim but chances are Debian will push new version through sooner than that. Either way I'll update this issue when it comes to that. It's sadly a low priority at the moment since I can work without ligatures.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5312483527@github.com>

[dezza]

dezza left a comment (vim/vim#21063)

I know absolutely nothing about ligatures nor have i tested for it, but I will gladly take a look if its reproducable across fonts using ligatures, my own choice of font CommitMono does as well.

It does look mistakenly like some of the redraw bugs I encountered while making #20528 so I can't deny its related.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5366406677@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

Absolutely the same behavior with this font as well.

https://github.com/user-attachments/assets/f746d992-8870-4c4f-9bfe-91b3972d32ab

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5379758290@github.com>

[dezza]

dezza left a comment (vim/vim#21063)

@MeanEYE don't worry I am taking responsibility and will look into this next in queue, just not going out of context right now.

As I remember this issue its very trivial, I will see later if I can fix it easy.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5381820065@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

That's great to hear. I kind of have my hands full these days. In short ligatures just render as a single character, but everything keeps its width, it's a fixed width font anyway. My naive assumption is that cursor rendering code and character rendering code either enter a race condition or there's an expectation to render one extra character, when in fact only one renders. But I guess you'll find out anyway :D

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5381913310@github.com>

[dezza]

dezza left a comment (vim/vim#21063)

@MeanEYE

I just did small test with just

set guiligatures=!\"#$%&()*+-./:<=>?@[]^_{\|~
set guifont=CommitMono\ 12\ Regular

I can't get it to happen, but I do see the signs changing when I use those in guiligatures, so something is happening.

Can you provide link to exact font and sample text to try the ciw on?

Do you use X11 or Wayland btw?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5383037989@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

Am on Gnome, using Wayland. All latest in Debian Testing.

This is the font am using.

font.zip

		// try to find activity from provided UUID
		$query = $this->db->prepare('SELECT `activity_id` FROM `uuid_lookup_index` WHERE `uuid` = ? LIMIT 1');
		$query->bind_param('s', $uuid);
		$query->execute();

		$data = $query->get_result();
		$row = $data->fetch_assoc();
		$query->close();

		// prepare result
		$result = null;
		if (is_array($row))
			$result = $row['activity_id'];

		return $result;

That's the code from my video.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5384478807@github.com>

[dezza]

dezza left a comment (vim/vim#21063)

Did you recreate with just set guiligatures and -u NONE or --clean ?

I have tried with

gvim -Nu NONE /tmp/vimtest.php +'syntax on|set guifont=Iosevka\ Custom|set guiligatures=!\"#$%&()*+-./:<=>?@[]^_{\|~'

Tried raising font size also.

I think you should try master/self-compile, or try to reduce to a minimal vimrc that reproduces the exact issue, cuz I can't reproduce it.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5405524688@github.com>

[Mladen Mijatov]

MeanEYE left a comment (vim/vim#21063)

This is -u NONE and guifont=Iosevka Custom 11 and guiligatures=->.

https://github.com/user-attachments/assets/da193571-8574-4e6b-a21a-40d7419b06a3

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5430744218@github.com>

[dezza]

dezza left a comment (vim/vim#21063)

You need to test the fixed patchlevel that addresses this, it will most likely work.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/21063/5433454688@github.com>