[vim/vim] Add Faust filetype (PR #14894)
Blake North
This adds the faust filetype for Faust .dsp and .lib files.
The .lib file extension was marked as being for COBOL files, but I couldn't find any evidence to support .lib being an extension that's used by COBOL (see sources below), so I reassigned it to Faust, which does use the .lib extension (example). If anyone can find a .lib file in COBOL, I'll gladly write a file type detector for it, but I would need to see it in order to know what I'm detecting.
Sources proving that COBOL doesn't use .lib:
- The Wikipedia article on COBOL does not list
.libas an extension
image.png (view on web) - Visual Studio's COBOL Language Support extension does not list
.libas an extension they detect as a COBOL file.
image.png (view on web) - The first 100 search results for
.libfiles on github are all in repos that do not contain any COBOL code
(verified by hand)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/14894
Commit Summary
- 9abe90d Add Faust filetype
File Changes
(1 file)
- M runtime/filetype.vim (5)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
It might be a good idea to email the Cobol runtime files maintainer (Ankit Jain aja...@yahoo.co.in) and see if they can offer an explanation for this extension. It appears to have been assigned to Cobol for at least twenty five years.
Linguist doesn't recognise it as a Cobol extension either.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Thanks. Another issue: *.dsp is already used for Makefiles
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Blake North
Yes, I just noticed that - I'll write a detector for it. It seems like checking for # characters at the beginnings of lines, no semicolons ; at the ends of lines, and looking for keywords like ifeq and endif could be a good way of doing this.
Example .dsp in Makefile: https://github.com/alberto-fc/csr-spi-ftdi/blob/21cda76812b916bb8e31097c389fe6b82fcb8512/obj-win32/Makefile.dsp
Example .dsp in Faust: https://github.com/magnetophon/lamb/blob/a2151cfd20c9827c92fb6fc092dc367b2b40d450/lamb.dsp
Also, I've never submitted a PR here before. Should this PR touch the same files as #12363?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Ankit
@PowerUser64 I think it is safe to remove .lib from COBOL filetype detector as it is not a standard COBOL extension. Standard types are .cbl and .cob and .cpy for copybooks.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
I think #12363 is a good example, which you can use as a template for you changes. Thanks for working on that.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Blake North
@PowerUser64 pushed 1 commit.
- 81a57b1 Add Faust filetype
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake North
Good news, it turns out that Make doesn't actually use the .dsp extension. Rather it's used by a discontinued program called Microsoft Developer Studio, hence the Developer Studio Project .dsp format. What's nice is these files are auto-generated, and all seem to have the same text at the top, "# Microsoft Developer Studio Project File". The format of the file is the same as that of Makefile, hence the association. I added in a few extra tests for things like keywords and comments for good measure.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Blake North
@PowerUser64 pushed 1 commit.
- 30d6028 Add Faust filetype
You are receiving this because you are subscribed to this thread.
Blake North
@PowerUser64 pushed 1 commit.
- e5ea5b3 Add Faust filetype
You are receiving this because you are subscribed to this thread.
Blake North
Cool, tests pass. By the way, any idea why https://github.com/vim/vim/actions/runs/9557808149/job/26345595245?pr=14894#step:11:15186 failed?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Thanks, those 2 failing ones are known flaky ones.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
thanks, looks good now.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Blake North
Thanks for the review!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.