[vim/vim] statusline: blend status line highlight into adjacent vsep cells (PR #20182)
h_east
Problem: When two windows are placed side by side with vsplit and
their status lines are connected (the cell between them
is drawn with the 'stl' / 'stlnc' fillchar, not the
'vert' character), that connecting cell still uses the
VertSplit highlight. The status line bar therefore
looks broken at the separator column, and any custom
edge highlight set in 'statusline' (%#XX# / %N*) is cut
off there.
Solution: Make that connecting cell take the highlight from the
neighbouring status line edge instead of VertSplit:
- Next to the current window, use the current
window's edge highlight, so the StatusLine bar (and
any %#... at the edge) extends into the column
without a seam.
- Between two non-current windows whose status
fillchar is a space, use the left window's
right-edge highlight, so the StatusLineNC bar is
continuous across the column too.
Cells drawn with the 'vert' character (the two windows
do not share a status line) keep the VertSplit
highlight as before.
Add Test_statusline_vsep_borrow_hl with two layouts
(NC | cur | NC | NC and NC | NC | cur | NC) so all
three cases above are covered.
Related: #19951
Related: #20089
Related: #20167
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20182
Commit Summary
- a5589ce statusline: blend status line highlight into adjacent vsep cells
File Changes
(3 files)
- M src/drawscreen.c (81)
- A src/testdir/dumps/Test_statusline_vsep_borrow_hl_02.dump (6)
- M src/testdir/test_statusline.vim (36)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#20182)@bfrg , Rob
I believe I've confirmed that there are no problems with the procedure you reported in #20089.
Please let me know if there are any frustrating changes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 04a7aa9 statusline: blend status line highlight into adjacent vsep cells
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 8b1ebed Fix CI test errors (due to specification changes in this PR)
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 5a790d9 Fix CI test errors (due to specification changes in this PR)
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- dcddb02 Fix CI test errors (due to specification changes in this PR)
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 816997f Fix CI test errors (due to specification changes in this PR)
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 4557070 Fix CI test errors (due to specification changes in this PR)
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#20182)Done.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.