K.Takata

unread,

Feb 21, 2022, 11:10:38 PM2/21/22

to vim/vim, Subscribed

Caught exception in Test_vartabstop_latin1(): Vim(set):E950: Cannot convert between cp1252 and iso-8859- @ command line..script D:/a/vim/vim/src/testdir/runtest.vim[456]..function RunTheTest[44]..Test_vartabstop_latin1, line 3

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/9818

Commit Summary

d87b61e CI: Fix 8.2.4436

File Changes

(1 file)

M src/testdir/test_vartabs.vim (2)

Patch Links:

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Feb 21, 2022, 11:29:33 PM2/21/22

to vim/vim, Subscribed

Hmm, it seems that this fixes the original error, but this causes another error:

Caught exception in Test_vartabstop_latin1(): Vim(set):E954: 24-bit colors are not supported on this environment: termguicolors @ command line..script D:/a/vim/vim/src2/testdir/runtest.vim[456]..function RunTheTest[44]..Test_vartabstop_latin1, line 4

It looks that silent norm :se ^A^[ doesn't work as expected on Windows. ^A completes all the option names, then ^[ doesn't clear the command line and the command is executed as if Enter is typed. Not sure why...

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Feb 22, 2022, 12:13:34 AM2/22/22

to vim_dev, reply+ACY5DGEDJEKZGU4JQO...@reply.github.com, vim/vim, Subscribed

Hi,

On Mon, Feb 21, 2022 at 8:29 PM K.Takata <vim-dev...@256bit.org> wrote:

Hmm, it seems that this fixes the original error, but this causes another error:

Caught exception in Test_vartabstop_latin1(): Vim(set):E954: 24-bit colors are not supported on this environment: termguicolors @ command line..script D:/a/vim/vim/src2/testdir/runtest.vim[456]..function RunTheTest[44]..Test_vartabstop_latin1, line 4

It looks that silent norm :se ^A^[ doesn't work as expected on Windows. ^A completes all the option names, then ^[ doesn't clear the command line and the command is executed as if Enter is typed. Not sure why...

In Vi-compatible mode, the escape key will execute the command and will not abort the

command line (see :help cpo-x).

- Yegappan

vim-dev ML

unread,

Feb 22, 2022, 12:13:50 AM2/22/22

to vim/vim, vim-dev ML, Your activity

Hi,

On Mon, Feb 21, 2022 at 8:29 PM K.Takata ***@***.***> wrote:

> Hmm, it seems that this fixes the original error, but this causes another
> error:
>
> Caught exception in Test_vartabstop_latin1(): Vim(set):E954: 24-bit colors
> are not supported on this environment: termguicolors @ command line..script

> D:/a/vim/vim/src2/testdir/runtest.vim[456]..function

> RunTheTest[44]..Test_vartabstop_latin1, line 4
>
> It looks that silent norm :se ^A^[ doesn't work as expected on Windows. ^A
> completes all the option names, then ^[ doesn't clear the command line
> and the command is executed as if Enter is typed. Not sure why...
>
>
> In Vi-compatible mode, the escape key will execute the command and will
not abort the
command line (see :help cpo-x).

- Yegappan

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Feb 22, 2022, 12:58:38 AM2/22/22

to vim/vim, vim-dev ML, Comment

Ah, :help c_Esc says that:

In macros or when 'x' present in 'cpoptions', start entered command.

:norm is like a macro, so Esc is handled like Enter.

I'm not sure what the line silent norm :se ^A^[ used for. Can we use ^C instead of ^[?

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

K.Takata

unread,

Feb 22, 2022, 1:00:15 AM2/22/22

to vim/vim, vim-dev ML, Push

@k-takata pushed 1 commit.

d0c0e3d Use Ctrl-C instead of Esc

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,

Feb 22, 2022, 1:08:20 AM2/22/22

to vim/vim, vim-dev ML, Comment

Codecov Report

Merging #9818 (d0c0e3d) into master (4e889f9) will decrease coverage by 2.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master    #9818      +/-   ##

==========================================

- Coverage   83.80%   81.01%   -2.79%     

==========================================

  Files         154      153       -1     

  Lines      175124   170832    -4292     

  Branches    39374    39371       -3     

==========================================

- Hits       146763   138400    -8363     

- Misses      16323    19171    +2848     

- Partials    12038    13261    +1223

Flag	Coverage Δ
huge-clang-none	`?`
huge-gcc-none	`?`
huge-gcc-testgui	`80.96% <ø> (-0.05%)`	⬇️
huge-gcc-unittests	`2.02% <ø> (ø)`
linux	`81.01% <ø> (-2.79%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/libvterm/src/rect.h	`0.00% <0.00%> (-96.78%)`	⬇️
src/libvterm/src/state.c	`38.12% <0.00%> (-51.05%)`	⬇️
src/libvterm/include/vterm.h	`0.00% <0.00%> (-44.45%)`	⬇️
src/libvterm/src/keyboard.c	`46.31% <0.00%> (-41.32%)`	⬇️
src/libvterm/src/mouse.c	`0.00% <0.00%> (-36.51%)`	⬇️
src/libvterm/src/encoding.c	`37.37% <0.00%> (-36.16%)`	⬇️
src/libvterm/src/pen.c	`47.61% <0.00%> (-36.09%)`	⬇️
src/libvterm/src/parser.c	`60.33% <0.00%> (-35.55%)`	⬇️
src/mouse.c	`48.61% <0.00%> (-31.41%)`	⬇️
src/libvterm/src/vterm.c	`39.81% <0.00%> (-26.57%)`	⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e889f9...d0c0e3d. Read the comment docs.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Christian Brabandt

unread,

Feb 22, 2022, 2:32:25 AM2/22/22

to vim/vim, vim-dev ML, Comment

Hm, E950 only happens when termencoding and encoding is different:

https://github.com/vim/vim/blob/4e889f98e95ac05d7c8bd3ee933ab4d47820fdfa/src/optionstr.c#L1026-L1036

So perhaps we need to set termencoding as well or make it empty? E.g.

set encoding=iso8859 termencoding=iso8859

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

K.Takata

unread,

Feb 22, 2022, 3:59:22 AM2/22/22

to vim/vim, vim-dev ML, Push

@k-takata pushed 1 commit.

6a6696c Use `exe` for readability

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Feb 22, 2022, 5:16:03 AM2/22/22

to vim/vim, vim-dev ML, Push

@k-takata pushed 1 commit.

530c3a4 Use iso8859-1 instead of latin1

—
View it on GitHub.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Feb 22, 2022, 6:05:19 AM2/22/22

to vim/vim, vim-dev ML, Comment

Closed #9818 via 0f113e4.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Reply all

Reply to author

Forward

[vim/vim] CI: Fix 8.2.4436 on Windows (PR #9818)

K.Takata

You can view, comment on, or merge this pull request online at:

Commit Summary

File Changes

Patch Links:

K.Takata

Yegappan Lakshmanan

vim-dev ML

K.Takata

K.Takata

codecov[bot]

Codecov Report

Christian Brabandt

K.Takata

K.Takata

Bram Moolenaar