[vim/vim] Vim9: error for an indexed item in :def does not name the variable (PR #21396)
h_east
Problem: Assigning to an item of a locked list, or indexing a type
that cannot be indexed, gives E1119 or E1141 in a :def
function, which do not name the variable, while the script
level gives E741, E742 or E689 with the name.
Solution: Give the same errors as the script level, with the name of
the destination. E1119 and E1141 are no longer used.
related: #21391
Note: this changes the error numbers in a :def function. E1119 becomes
E741 or E742, and E1141 becomes E689, the same as at the script level.
A script that catches E1119 or E1141 needs to be updated.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21396
Commit Summary
- e240fc7 Vim9: error for an indexed item in :def does not name the variable
File Changes
(14 files)
- M runtime/doc/eval.txt (4)
- M runtime/doc/tags (2)
- M runtime/doc/vim9.txt (3)
- M src/errors.h (6)
- M src/testdir/test_listdict.vim (2)
- M src/testdir/test_tuple.vim (2)
- M src/testdir/test_vim9_assign.vim (11)
- M src/testdir/test_vim9_class.vim (6)
- M src/testdir/test_vim9_cmd.vim (12)
- M src/testdir/test_vim9_script.vim (2)
- M src/vim9.h (1)
- M src/vim9compile.c (10)
- M src/vim9execute.c (4)
- M src/vim9instr.c (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21396)I am slightly worried about the changed error numbers. Do you think this causes any issues for plugin writers?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#21396)Agreed. Since we can't completely rule out the possibility of issues arising, let's put this PR on hold for now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#21396)I handled this without changing the error number.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.