[vim/vim] CI,macOS: delayed-payload test fails too often (Issue #15395)
K.Takata
Steps to reproduce
The delayed-payload test in Test_channel_lsp_mode() in test_channel.vim fails very often on macOS in the CI and it is very annoying. E.g.:
https://github.com/vim/vim/actions/runs/10138911297/job/28031332621?pr=15386
Failures:
From test_channel.vim:
Found errors in Test_channel_lsp_mode():
Run 1, 06:16:36 - 06:16:48:
command line..script /Users/runner/work/vim/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_channel_lsp_mode[1]..RunServer[21]..LspTests line 117: Expected {'id': 15, 'jsonrpc': '2.0', 'result': 'delayed-payload'} but got {}
Expected behaviour
The delayed-payload test doesn't fail on macOS.
Version of Vim
9.1.0640
Environment
macOS
Logs and stack traces
No response
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
K.Takata
Here is the code of the delayed-payload test:
https://github.com/vim/vim/blob/1254e6db8360fac99561ef0f10ac3cb1bfef30b1/src/testdir/test_channel_lsp.py#L93-L103
It send the header first and then after 0.05 sec delay, send the payload.
Does anyone look into this?
I suspect if there is a timeout issue in the macOS implementation...
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yee Cheng Chin
I suspect if there is a timeout issue in the macOS implementation...
I feel like this happens so often in macOS that it's worth taking a look at. I could take a look a bit later. In general timing seems very flaky in macOS GitHub Actions CI, but I can never replicate any of these bugs locally, so it at least indicates some issues with the interactions with GH Actions' CI environment. It's not clear if there's something else with the actual Mac implementation or not though.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yee Cheng Chin
Is it actually still failing in recent CI? I couldn't quite see it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
K.Takata
k-takata left a comment (vim/vim#15395)It seems this hasn't occurred recently. Closing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.