[vim/vim] tests: Test_screenpos() is flaky in GUI (PR #20457)

thinca

unread,

1:51 PM (9 hours ago) 1:51 PM

to vim/vim, Subscribed

Problem: Test_screenpos() fails intermittently in the GUI testgui CI job with "Expected {'row': 22} but got {'row': 23}". In the GUI, the window height reported by getwininfo() before the final redraw can be stale, so the cached wininfo.height does not match the actual window height when the assertion runs.

Solution: Use winheight(winid) at assertion time so the height reflects the window state after the redraw.

This PR is powered by Claude Code.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20457

Commit Summary

91ccbd0 tests: Test_screenpos() is flaky in GUI

File Changes

(1 file)

M src/testdir/test_cursor_func.vim (2)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

2:40 PM (8 hours ago) 2:40 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20457)

Thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

3:01 PM (8 hours ago) 3:01 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20457)

I forgot to add the AI disclaimer to the commit. Can you please next time include the AI disclaimer to the commit message?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

thinca

unread,

8:09 PM (2 hours ago) 8:09 PM

to vim/vim, Subscribed

thinca left a comment (vim/vim#20457)

Understood. I'll add Co-Authored-By next time.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward