[vim/vim] fix: tabpanel with cmdline-pum issue (PR #17549)

5 views
Skip to first unread message

h_east

unread,
Jun 15, 2025, 9:28:37 AMJun 15
to vim/vim, Subscribed

How to repro.

  1. Start Vim with some args.
$ vim --clean --cmd "lang C" +"set stpl=2 wop=pum"
  1. type :set and Hit Tab key.
    Command line pop up menu displayed.
  2. Change terminal columns by mouse.

Unexpected behaiviour

  • tabpanel disappears.
  • It appears when I execute :redrawtabpanel, but disappears when I press <C-l>.

Investigation result

  • There is an unnecessary pum-related check in the tabpanel_leftcol() function.

Solution

  • Delete unnecessary pum-related checks in the tabpanel_leftcol() function.
  • And the refactorings mentioned above
    • The argument of the TPL_LCOL() macro has been deleted.
    • The argument of the tabpanel_leftcol() function has been changed to void.
    • The return value of the win_comp_pos() function has been changed to void.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/17549

Commit Summary

  • b723b17 fix: tabpanel with cmdline-pum issue

File Changes

(9 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17549@github.com>

Christian Brabandt

unread,
Jun 16, 2025, 1:37:32 PMJun 16
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#17549)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17549/c2977469427@github.com>

Christian Brabandt

unread,
Jun 16, 2025, 1:45:37 PMJun 16
to vim/vim, Subscribed

Closed #17549 via e5c96e3.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/17549/issue_event/18175316425@github.com>

Reply all
Reply to author
Forward
0 new messages