Patch 8.2.0890

[Bram Moolenaar]

Patch 8.2.0890
Problem: No color in terminal window when 'termguicolor' is set.
Solution: Clear the underline color. (closes #6186)
Files: src/highlight.c


*** ../vim-8.2.0889/src/highlight.c 2020-05-31 16:41:04.646603340 +0200
--- src/highlight.c 2020-06-02 23:16:05.904351265 +0200
***************
*** 2230,2239 ****
--- 2230,2241 ----
#ifdef FEAT_TERMGUICOLORS
at_en.ae_u.cterm.fg_rgb = INVALCOLOR;
at_en.ae_u.cterm.bg_rgb = INVALCOLOR;
+ at_en.ae_u.cterm.ul_rgb = INVALCOLOR;
#endif
at_en.ae_attr = attr;
at_en.ae_u.cterm.fg_color = fg;
at_en.ae_u.cterm.bg_color = bg;
+ at_en.ae_u.cterm.ul_color = INVALCOLOR;
return get_attr_entry(&cterm_attr_table, &at_en);
}
#endif
***************
*** 2262,2267 ****
--- 2264,2270 ----
at_en.ae_u.cterm.fg_rgb = fg;
at_en.ae_u.cterm.bg_rgb = bg;
}
+ at_en.ae_u.cterm.ul_rgb = INVALCOLOR;
return get_attr_entry(&cterm_attr_table, &at_en);
}
#endif
*** ../vim-8.2.0889/src/version.c 2020-06-02 22:24:33.153439212 +0200
--- src/version.c 2020-06-02 22:43:12.450608910 +0200
***************
*** 748,749 ****
--- 748,751 ----
{ /* Add new patch number below this line */
+ /**/
+ 890,
/**/

--
hundred-and-one symptoms of being an internet addict:
262. Your computer has it's own phone line - but your daughter doesn't.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Dominique Pellé]

Bram Moolenaar wrote:

> Patch 8.2.0890
> Problem: No color in terminal window when 'termguicolor' is set.
> Solution: Clear the underline color. (closes #6186)
> Files: src/highlight.c

Patch 8.2.0890 introduces a compilation warning:

gcc -c -I. -Iproto -DHAVE_CONFIG_H -g -O2 -D_REENTRANT
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DEXITFREE -o
objects/highlight.o highlight.c
In file included from vim.h:1812:0,
from highlight.c:15:
highlight.c: In function ‘get_cterm_attr_idx’:
structs.h:116:21: warning: large integer implicitly truncated to
unsigned type [-Woverflow]
# define INVALCOLOR ((guicolor_T)0x1ffffff)
^
highlight.c:2238:33: note: in expansion of macro ‘INVALCOLOR’
at_en.ae_u.cterm.ul_color = INVALCOLOR;
^~~~~~~~~~

at_en.ae_u.ul_color is a 'short_u' type.

Dominique

[Bram Moolenaar]

Yeah, INVALCOLOR is for the RGB color, here it should be zero.

Libvterm doesn't support the underline color. Should not be too
difficult to add.

--
hundred-and-one symptoms of being an internet addict:

264. You turn to the teletext page "surfing report" and are surprised that it
is about sizes of waves and a weather forecast for seaside resorts.