[vim/vim] Fix: Issue 18488 (PR #18497)

girish

unread,

Oct 5, 2025, 2:40:11 PM (2 days ago) Oct 5

to vim/vim, Subscribed

NOTE: If completion items are already fuzzy-sorted during collection (for example, when a user or omni function returns a pre-sorted list), an additional redundant sort will still occur within the completion mechanism. This is harmless — the list is typically small, and the sorting operation (O(N log N)) remains efficient even for linked lists. No need for premature optimization.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18497

Commit Summary

039b6fc Fix: Issue 18488

File Changes

(2 files)

M src/insexpand.c (48)
M src/testdir/test_ins_complete.vim (17)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

ddad431

unread,

Oct 5, 2025, 9:27:49 PM (2 days ago) Oct 5

to vim/vim, Subscribed

ddad431 left a comment (vim/vim#18497)

This pr give sorted list is different with typing resort list. Is this expected or an error?

set cfc=keyword cot+=noselect,fuzzy
augroup group_vim_ins_completion
    autocmd!
    autocmd FileType vim
                \ setlocal omnifunc=vimcomplete#Complete |
                \ setlocal complete+=o^7
augroup END

before
image.png (view on web)

resort by <C-h><BeforeChar>
image.png (view on web)

this pr
image.png (view on web)

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 6, 2025, 8:34:22 AM (yesterday) Oct 6

to vim/vim, Push

@girishji pushed 1 commit.

cc3165e Fix: fuzzy sort candidates from sources other than curbuf

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 6, 2025, 8:34:49 AM (yesterday) Oct 6

to vim/vim, Subscribed

girishji left a comment (vim/vim#18497)

There was a bug. Pl. try now.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

ddad431

unread,

Oct 6, 2025, 8:42:19 AM (yesterday) Oct 6

to vim/vim, Subscribed

ddad431 left a comment (vim/vim#18497)

I have tested, no problem.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Oct 6, 2025, 3:03:10 PM (20 hours ago) Oct 6

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#18497)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Oct 6, 2025, 3:10:25 PM (20 hours ago) Oct 6

to vim/vim, Subscribed

Closed #18497 via 10aa04e.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

girish

unread,

2:41 AM (8 hours ago) 2:41 AM

to vim/vim, Subscribed

girishji left a comment (vim/vim#18497)