Re: [vim/vim] patch 9.0.0815 (9c50eeb)
Christian Brabandt
Hi Bram,
now we are missing description of the patch and we still do not have a tag :(
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Björn Steinbrink
This causes an immediate use-after-free, doesn't it?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Björn Steinbrink
Yeah, reverting this fixing both the segfault and the broken :! behaviour I mentioned in #11409 (comment)
And from 9.0.0783 and 9.0.0785 this doesn't seem necessary. What am I missing?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
It seems that there was a memory leak in the PR.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Björn Steinbrink
Oh, you mean #11420? Yeah, taking a closer look, that seems to be the case, thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Björn Steinbrink
AFAICT this will cause :! to redo the previous command if shellquote is set, because the quoting code below uses prevcmd
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Christian wrote:
> now we are missing description of the patch and we still do not have a tag :(
--
If you don't get everything you want, think of
everything you didn't get and don't want.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
I thought I had fixed the problems, but now I see the filetype test is
failing. Can someone see why? It's like the Mac file just disappears.
--
Eye have a spelling checker, it came with my PC;
It plainly marks four my revue mistakes I cannot sea.
I've run this poem threw it, I'm sure your please to no,
It's letter perfect in it's weigh, my checker tolled me sew!
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/vim/vim/commit/9c50eeb40117413bf59a9da904c8d0921ed0a6e6/88233761%40github.com.
vim-dev ML
'endoffile' option change.
I'm too tired right now to look into it. Helps a lot if someone can provide
a PR.
wrote:
>
> I thought I had fixed the problems, but now I see the filetype test is
> failing. Can someone see why? It's like the Mac file just disappears.
>
> --
> Eye have a spelling checker, it came with my PC;
> It plainly marks four my revue mistakes I cannot sea.
> I've run this poem threw it, I'm sure your please to no,
> It's letter perfect in it's weigh, my checker tolled me sew!
>
> /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
> /// \\\
> \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
> \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
>
> —
> Reply to this email directly, view it on GitHub
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: <vim/vim/commit/9c50eeb40117413bf59a9da904c8d0921ed0a6e6/88233761@
> github.com>
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/vim_dev/vim/vim/commit/9c50eeb40117413bf59a9da904c8d0921ed0a6e6/88233761%40github.com
> .
>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Anton Sharonov (ant0sha)
I thought I had fixed the problems, but now I see the filetype test is failing. Can someone see why? It's like the Mac file just disappears.
I mean the fileformat test, filetype looks OK. Probably related to the 'endoffile' option change.
Seems to be fixed with 9.0.0819
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.