[vim/vim] Move the functions handling the runtime directory and the files to runtime.c (#4861)

[Yegappan Lakshmanan]

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/4861

Commit Summary

• Move runtime directory related functions to runtime.c

File Changes

• M Filelist (2)
• M src/Make_cyg_ming.mak (1)
• M src/Make_morph.mak (1)
• M src/Make_mvc.mak (4)
• M src/Make_vms.mms (6)
• M src/Makefile (10)
• M src/README.md (1)
• M src/cmdexpand.c (156)
• M src/ex_cmds2.c (587)
• M src/proto.h (1)
• M src/proto/ex_cmds2.pro (9)
• A src/proto/runtime.pro (13)
• A src/runtime.c (755)

Patch Links:

• https://github.com/vim/vim/pull/4861.patch
• https://github.com/vim/vim/pull/4861.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

[Codecov]

Codecov Report

Merging #4861 into master will decrease coverage by 0.01%.
The diff coverage is 92.92%.

@@            Coverage Diff             @@

##           master    #4861      +/-   ##

==========================================

- Coverage    81.6%   81.58%   -0.02%     

==========================================

  Files         120      121       +1     

  Lines      145949   145949              

==========================================

- Hits       119097   119079      -18     

- Misses      26852    26870      +18

Impacted Files	Coverage Δ
src/ex_cmds2.c	85.01% <ø> (-1.88%)	⬇️
src/cmdexpand.c	78.96% <ø> (-0.5%)	⬇️
src/runtime.c	92.92% <92.92%> (ø)
src/ui.c	68.98% <0%> (-0.97%)	⬇️
src/viminfo.c	75.11% <0%> (-0.2%)	⬇️
src/os_unix.c	63.27% <0%> (-0.18%)	⬇️
src/window.c	87.76% <0%> (-0.04%)	⬇️
src/gui.c	63.8% <0%> (+0.05%)	⬆️
src/if_xcmdsrv.c	86.71% <0%> (+0.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4645104...b6e8e3c. Read the comment docs.

—
You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or mute the thread.

[Bram Moolenaar]

Hmm, this is not a big improvement, ex_cmds2.c isn't that big and
runtime.c only ends up being 755 lines. Can perhaps also move
do_source() there. That would include "struct source_cookie" and what
depends on it. Could call it scriptfile.c then.

For further moves, it's best to look at the large files, the ones that
are around 200 Kbyte or more.

--
hundred-and-one symptoms of being an internet addict:
112. You are amazed that anyone uses a phone without data...let
alone hear actual voices.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 20ae5a0 Rename runtime.c to scriptfile.c and move functions related to sourcing scripts to it

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

[Yegappan Lakshmanan]

Hi Bram,

On Sat, Aug 24, 2019 at 10:25 AM Bram Moolenaar
<vim-dev...@256bit.org> wrote:
>
>
> Hmm, this is not a big improvement, ex_cmds2.c isn't that big and
> runtime.c only ends up being 755 lines. Can perhaps also move
> do_source() there. That would include "struct source_cookie" and what
> depends on it. Could call it scriptfile.c then.
>

I initially moved the do_source() related functions also to the runtime.c
file. But as these two are not related to each other, I revered the change.
I have updated the PR to rename the file to scriptfile.c and moved the
do_source() functions.

>
> For further moves, it's best to look at the large files, the ones that
> are around 200 Kbyte or more.
>

Regards,
Yegappan

[vim-dev ML]

[Bram Moolenaar]

Closed #4861 via 307c5a5.

—
You are receiving this because you commented.