[vim/vim] GTK4: Add option to use hardware accelerated rendering backend (PR #20437)
Foxe Chen
Add configure option --enable-gtk4-hwaccel to use GtkSnapshot for rendering in the GTK4 GUI.
Compared to #20324, the implementation is cleaner and more readable. I tried experimenting with other possible ways to make things simpler, but I did not get very far.
The performance boost on my machine is noticeable (both compiled using same optimized flags with laptop running on battery):
Current rendering path:
https://github.com/user-attachments/assets/d8cab615-ed3e-4226-a07b-5c6dac24a9a4
The excessive lag at the start is probably due to the CPU being too slow to react? However that may as well also be another issue.
Hardawre accelerated rendering path:
https://github.com/user-attachments/assets/4947881b-fff1-4382-87a3-8d1c58793ae2
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20437
Commit Summary
- ba89381 initial commit
- cf3ad5b basic glyph drawing working
- 43ea541 refactor
- 38111e9 implement invert
- c91830b fix bugs
- f857cb0 fix undercurl
- 268bfc1 implement signs
- 8ad9db2 fix gui_mch_insert_lines()
- c01ad0f implement netbeans multisign
File Changes
(12 files)
- M src/Makefile (15)
- M src/auto/configure (136)
- M src/config.h.in (6)
- M src/configure.ac (35)
- M src/feature.h (3)
- M src/gui.c (9)
- M src/gui.h (2)
- M src/gui_gtk4.c (218)
- A src/gui_gtk4_da.c (1261)
- A src/gui_gtk4_da.h (37)
- M src/netbeans.c (12)
- M src/proto/gui_gtk4.pro (2)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
arkissa
Arkissa left a comment (vim/vim#20437)IMO, For users who build Vim themselves, GTK4 hwaccel should probably be auto rather than manual opt-in. GTK4/GSK can choose the appropriate renderer based on the runtime environment, and better accelerated rendering is one of the main reasons to choose GTK4 over GTK3.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20437)IMO, For users who build Vim themselves, GTK4 hwaccel should probably be auto rather than manual opt-in. GTK4/GSK can choose the appropriate renderer based on the runtime environment, and better accelerated rendering is one of the main reasons to choose GTK4 over GTK3.
I think we should initially keep it optional for now for a bit so users can test and report any bugs/crashes. Then when its stable enough we can fully switch over.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.