[vim/vim] When adding a new item at the end of a list in vim9script, use the proper item type (PR #19076)

Yegappan Lakshmanan

unread,

Jan 3, 2026, 3:55:19 PMJan 3

to vim/vim, Subscribed

In a Vim9 script, a new item can be appended to a list by using the list length
as the index. When doing this, Vim initially adds a number as the new item.
This led to the type error reported in #19045. Instead of using a number as the
new item, this change creates a new item based on the proper type before
adding it to the list.

Fixes the issue reported in #19045.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19076

Commit Summary

ab49605 When adding a new item at the end of a list in vim9script, use the proper item type

File Changes

(2 files)

M src/list.c (54)
M src/testdir/test_listdict.vim (101)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 3, 2026, 3:58:12 PMJan 3

to vim/vim, Push

@yegappan pushed 1 commit.

6e8e462 Check for NULL return from check_range_index_one()

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 3, 2026, 4:20:56 PMJan 3

to vim/vim, Push

@yegappan pushed 1 commit.

0655066 Fix test failures

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 4, 2026, 8:35:36 PMJan 4

to vim/vim, Push

@yegappan pushed 1 commit.

6967d9e When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 5, 2026, 1:47:56 AMJan 5

to vim/vim, Push

@yegappan pushed 1 commit.

c96b3b7 When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 6, 2026, 10:51:58 AMJan 6

to vim/vim, Push

@yegappan pushed 1 commit.

a07c22b When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 6, 2026, 1:19:56 PMJan 6

to vim/vim, Push

@yegappan pushed 1 commit.

6ebf749 When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 12:23:58 AMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

6fc4e6d When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 1:20:53 AMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

51d9a1c Support adding new item to a list for different types

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 1:47:58 AMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

72997e9 Fix asan failure

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 11:49:32 AMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

f1c871d When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 4:18:34 PMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

ccbb028 When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 8, 2026, 6:03:43 PMJan 8

to vim/vim, Push

@yegappan pushed 1 commit.

1a6a00f When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 9, 2026, 12:39:30 AMJan 9

to vim/vim, Push

@yegappan pushed 1 commit.

8f70c46 When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 9, 2026, 12:43:31 AMJan 9

to vim/vim, Subscribed

yegappan left a comment (vim/vim#19076)

This PR is now ready.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Jan 9, 2026, 3:19:05 PMJan 9

to vim/vim, Push

@yegappan pushed 1 commit.

db5747a When adding a new item at the end of a list in vim9script, use the proper item type

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 10, 2026, 1:12:01 PMJan 10

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19076)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 10, 2026, 1:19:00 PMJan 10

to vim/vim, Subscribed

Closed #19076 via 949e3be.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward