[vim/vim] Feat: Add more settings to 'completepopup' (PR #18487)

girish

unread,

Oct 4, 2025, 4:37:59 AM (7 days ago) Oct 4

to vim/vim, Subscribed

Should be merged after #18486.

This patch extends the 'completepopup' option with additional settings. Also, adds "shadow" effect to the info popup window.

New values:

	close		show close button: "on" (default) or "off"
	resize		show resize handle: "on" (default) or "off"
	borderchars	eight characters separated by semicolons, in the
		        order: top, right, bottom, left,
			    topleft, topright, botright, botleft.
	borderhighlight	highlight group of the popup border characters
	shadow		"off" (default) or "on" using |hl-PmenuShadow|

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18487

Commit Summary

e96c68d Feat: Add more settable values to 'completepopup'
e6d9d6c Add shadow to info window
1a1f578 fix tags
9ea41dd Fix test failure
331c52e Merge branch 'vim:master' into infoshad

File Changes

(13 files)

M runtime/doc/insert.txt (12)
M src/highlight.c (4)
M src/optiondefs.h (2)
M src/optionstr.c (29)
M src/popupmenu.c (13)
M src/popupwin.c (126)
M src/proto/popupmenu.pro (1)
M src/structs.h (1)
A src/testdir/dumps/Test_popupwin_infopopup_9.dump (14)
M src/testdir/test_highlight.vim (2)
M src/testdir/test_options.vim (2)
M src/testdir/test_popupwin.vim (6)
M src/vim.h (4)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 4, 2025, 5:06:56 AM (7 days ago) Oct 4

to vim/vim, Push

@girishji pushed 1 commit.

2d05615 Fix test failure

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 4, 2025, 4:19:29 PM (6 days ago) Oct 4

to vim/vim, Push

@girishji pushed 1 commit.

8d3b36f Fix test failure

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 4, 2025, 4:19:50 PM (6 days ago) Oct 4

to vim/vim, Push

@girishji pushed 1 commit.

56fe83c Merge branch 'vim:master' into infoshad

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 8, 2025, 4:06:40 AM (3 days ago) Oct 8

to vim/vim, Push

@girishji pushed 1 commit.

1488a06 Feat: Add more settable values to 'completepopup'

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

Oct 9, 2025, 6:29:22 AM (yesterday) Oct 9

to vim/vim, Subscribed

habamax left a comment (vim/vim#18487)

is it feasible to extend border too to have values similar to pumborder, e.g.

on/off as of now

plus the next implying on:

	"single"	use thin box-drawing characters
	"double"	use double-line box-drawing characters
	"round"		use rounded corners
	"ascii"		use ASCII characters (-, |, +)
	"custom:X;X;X;X;X;X;X;X"
			use eight characters separated by semicolons, in the
			order: top, right, bottom, left,
			topleft, topright, botright, botleft

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

girish

unread,

Oct 9, 2025, 11:50:29 AM (yesterday) Oct 9

to vim/vim, Subscribed

girishji left a comment (vim/vim#18487)

You want to replace on and off with those values? How to keep it backward compatible?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Oct 9, 2025, 4:36:23 PM (yesterday) Oct 9

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#18487)

I don't think this would work and I think it would break scripts that query the popup_getoptions() value (also the return value is strange according to the documentation). Instead perhaps use "borderstyle"?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

Oct 9, 2025, 4:41:57 PM (yesterday) Oct 9

to vim/vim, Subscribed

habamax left a comment (vim/vim#18487)

Indeed, borderstyle sounds better.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

Oct 9, 2025, 7:53:44 PM (22 hours ago) Oct 9

to vim/vim, Subscribed

habamax left a comment (vim/vim#18487)

You want to replace on and off with those values?

Or, make on=double but keep it hidden for backward compatibility.

I was about on being an alias of double, off is just off, and the rest is just additional values of border. With this it would have been backward compatible and aligned with pumborder.