[vim/vim] add tombi linter for TOML files (PR #18590)
Enno
See https://github.com/tombi-toml/tombi
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18590
Commit Summary
- deb4c76 add tombi linter for TOML files
File Changes
(3 files)
- A runtime/compiler/tombi.vim (19)
- M runtime/doc/quickfix.txt (8)
- M runtime/doc/tags (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
Konfekt left a comment (vim/vim#18590)Failing tests due to
Run 3, 14:21:29 - 14:21:34 in 5.114939 seconds:
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui line 24: Pattern '1' does not match 'E247: No registered server named "VIMTESTSOCKET": Send expression failed.\n'
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui[29]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>27 line 1: Expected 'dead' but got 'run'
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui line 32: Server did not exit
seem unrelated?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#18590)Failing tests due to
Run 3, 14:21:29 - 14:21:34 in 5.114939 seconds: command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui line 24: Pattern '1' does not match 'E247: No registered server named "VIMTESTSOCKET": Send expression failed.\n' command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui[29]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>27 line 1: Expected 'dead' but got 'run' command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_socket_server_server_gui line 32: Server did not exitseem unrelated?
Yes it is unrelated, this PR fixes them #18586
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18590)Having to use sed to strip color codes bothers me a bit. I filed tombi-toml/tombi#1172 for this.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
Konfekt left a comment (vim/vim#18590)Having to use sed to strip color codes bothers me a bit
Thank you, I can relate that such a hack feels unsatisfying; thank you for filing that issue
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
@Konfekt pushed 1 commit.
- b9311ac Update tombi.vim for version checks and error handling
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Enno
Konfekt left a comment (vim/vim#18590)That went fast. Very responsive. I've adapted the compiler file accordingly.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18590)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
Konfekt left a comment (vim/vim#18590)Wait a second, there's a typo in let l:pa = map(split(a:ver),
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18590)sorry, I'll fix it
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns commented on this pull request.
In runtime/compiler/tombi.vim:
> + if l:pa[i] > l:pb[i] | return 1
+ elseif l:pa[i] < l:pb[i] | return 0
+ endif
+ endfor
+ return 1
+ endfunction
+ let s:tombi_nocolor = s:VersionGE(s:tombi_ver, '0.6.40')
+ delfunction s:VersionGE
+endif
+
+if s:tombi_nocolor
+ if has('win32')
+ if &shell =~# '\v<%(cmd|cmd)>'
+ CompilerSet makeprg=set\ NO_COLOR=1\ &&\ tombi\ lint
+ elseif &shell =~# '\v<%(powershell|pwsh)>'
+ CompilerSet makeprg=$env:NO_COLOR="1";\ tombi\ lint
@Konfekt, I would think that the "1"/\ tombi\ lint is parsed as a comment here?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Enno
@Konfekt commented on this pull request.
In runtime/compiler/tombi.vim:
> + if l:pa[i] > l:pb[i] | return 1
+ elseif l:pa[i] < l:pb[i] | return 0
+ endif
+ endfor
+ return 1
+ endfunction
+ let s:tombi_nocolor = s:VersionGE(s:tombi_ver, '0.6.40')
+ delfunction s:VersionGE
+endif
+
+if s:tombi_nocolor
+ if has('win32')
+ if &shell =~# '\v<%(cmd|cmd)>'
+ CompilerSet makeprg=set\ NO_COLOR=1\ &&\ tombi\ lint
+ elseif &shell =~# '\v<%(powershell|pwsh)>'
+ CompilerSet makeprg=$env:NO_COLOR="1";\ tombi\ lint
Oops, that's right. Powershell understands single quotes, it seems, but (escaped) double quotes are safer to pass for shell escaping
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.