[vim/vim] Implement popup image feature using Kitty graphics protocol properly (PR #21018)
Foxe Chen
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21018
Commit Summary
- bd8ebe6 Implement popup image feature using kgp properly
File Changes
(9 files)
- M src/evalfunc.c (147)
- M src/feature.h (1)
- M src/kitty.c (214)
- M src/misc2.c (137)
- M src/popupwin.c (187)
- M src/proto/kitty.pro (5)
- M src/proto/misc2.pro (3)
- M src/screen.c (2)
- M src/structs.h (15)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#21018)Also, claude suggests that the base64 actually fixes a bug in the base64 encoding?
e.g. :echo base64_encode(0z010002)
Sorry, what do you mean by this? Did :echo base64_encode(0z010002) behave wrong before this PR?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21018)Sorry, what do you mean by this? Did :echo base64_encode(0z010002) behave wrong before this PR?
It adds padding at the wrong position:
:echo base64_encode(0z010002)
AQ=C
:call writefile(0z010002, '/tmp/blob')
:!openssl base64 < /tmp/blob
AQAC
So I suggest to factor out the base64 related changes to a separate commit which includes a test for this.
Thanks,
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.