[vim/vim] runtime(plsql): set com, cms options (PR #17483)
Riley Bruins
It uses the same -- syntax as SQL, plus /* */ for multiline comments
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/17483
Commit Summary
- d8f90f5 runtime(plsql): set com, cms options
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#17483)ping @lee-lindley
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Lee Lindley
lee-lindley left a comment (vim/vim#17483)Not sure what you are trying to do, but this code is maintained in my repo as noted in the comment right above our first change. https://github.com/lee-lindley/vim_plsql_syntax
I merge it into my repo, test for a while, then I submit the change to vim as the maintainer.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Riley Bruins
ribru17 left a comment (vim/vim#17483)Sure, I can make a PR there. Just adds the 'comments' and 'commentstring' options.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Lee Lindley
lee-lindley left a comment (vim/vim#17483)Is there an explanation for why this is desirable?
--
Lee Lindley
***@***.***
From: Riley Bruins ***@***.***>
Sent: Monday, June 9, 2025 6:08 PM
To: vim/vim ***@***.***>
Cc: Lee Lindley ***@***.***>; Mention ***@***.***>
Subject: Re: [vim/vim] runtime(plsql): set com, cms options (PR #17483)
<https://avatars.githubusercontent.com/u/55766287?s=20&v=4> ribru17 left a comment (vim/vim#17483) <https://github.com/vim/vim/pull/17483#issuecomment-2957143725>
Sure, I can make a PR there. Just adds the 'comments' and 'commentstring' options.
—
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AU4D5LBQWS6KU2JWMRBUAF33CYASHA5CNFSM6AAAAAB63PQM2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVQIJXK2.gif> Message ID: ***@***.*** ***@***.***> >
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Riley Bruins
ribru17 left a comment (vim/vim#17483)The comments option is helpful for formatoptions (see :h fo-table), and is supported my many ftplugins.
As explained in :h commentstring, this option is used to add foldmarkers (it specifies what a valid comment string is for a particular programming language, :h fold-marker) and is also utilized by comment plugins to toggle comments for lines, such as vim-commentary
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#17483)closing in favor of lee-lindley/vim_plsql_syntax#5. @lee-lindley please handle it how you'd like to. It is your decision.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Closed #17483.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.