[vim/vim] fix(statusline): prevent various buffer overflows with item groups (PR #20522)

2 views
Skip to first unread message

Sébastien Hoffmann

unread,
6:47 AM (6 hours ago) 6:47 AM
to vim/vim, Subscribed

see neovim/neovim#40219


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20522

Commit Summary

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20522@github.com>

Sébastien Hoffmann

unread,
8:08 AM (5 hours ago) 8:08 AM
to vim/vim, Subscribed
epithet left a comment (vim/vim#20522)

Hi, first-time contributor here. I need some guidance on the failing code coverage check. I think, to cover the uncovered lines, I would need to create a vimscript unit test that depends on MAXPATHL. Do you know how I could do that in a portable fashion? Or do you maybe have some alternative idea?


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20522/c4701693982@github.com>

Christian Brabandt

unread,
10:03 AM (3 hours ago) 10:03 AM
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#20522)

I am not sure why codecov fails here. The test seems to check for the fixes, so this is not something blocking the PR here. If I read the patch correctly it seems to be fine and fix overflow correctly.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20522/c4701977222@github.com>

Reply all
Reply to author
Forward
0 new messages